Proposing for Lucid: - The change only affects new podcasts that are downloaded - Test case: 1. Open Rhythmbox 2. Add http://deimos3.apple.com/WebObjects/Core.woa/Feed/cmu.edu.1335575211.01335575214 as a podcast (Ctrl+P) 3. Download 2 tracks in the podcast 4. Confirm the tracks are different (in the current version they will be the same)
Patch: diff --git a/podcast/rb-podcast-manager.c b/podcast/rb-podcast-manager.c index c220bf2..c23c320 100644 --- a/podcast/rb-podcast-manager.c +++ b/podcast/rb-podcast-manager.c @@ -29,6 +29,7 @@ #include "config.h" #include <string.h> +#include <ctype.h> #define __USE_XOPEN #include <time.h> @@ -790,9 +791,15 @@ download_podcast (GFileInfo *src_info, RBPodcastManagerInfo *data) } if (local_file_name == NULL) { - /* fall back to the basename from the original URI */ - local_file_name = g_file_get_basename (data->source); - rb_debug ("didn't get a filename from the file info request; using basename %s", local_file_name); + char *c; + + /* fall back to the escaped URI */ + local_file_name = g_file_get_uri (data->source); + for (c = local_file_name; *c; c++) { + if (!isalnum (*c) && *c != '.') + *c = '-'; + } + rb_debug ("didn't get a filename from the file info request; using escaped uri %s", local_file_name); } /* if the filename ends with the query string from the original URI, -- -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs