Tormod, your patch adds this bound-checking code:

if (i<tiff || i>readsize) return PATCH_EXIF_NO_TIFF;

Comments:

1) I don't think it is possible for (i < tiff) to ever occur in the
code. Is it?

2) I think "i>readsize" should actually be "i>=readsize". Right?


- Mike

-- 
gthumb[15566]: segfault at 5126c60f eip b7f7bfe6 esp bf9bab08 error 4
https://bugs.launchpad.net/bugs/316017
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gthumb in ubuntu.

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to