On Sat, 2008-03-22 at 17:55 +0100, Julien Cristau wrote:
> On Thu, Mar 20, 2008 at 11:53:37 +0100, Michel Dänzer wrote:
>
> >
> > On Wed, 2008-03-19 at 22:13 +0100, Julien Cristau wrote:
> > > from hw/xfree86/exa/examodule.c:
> > > if (xf86IsOptionSet(pScreenPriv->options, EXAOPT_NO_COMPOSITE)) {
> > > xf86DrvMsg(pScreen->myNum, X_INFO,
> > > "EXA: Disabling Composite operation "
> > > "(RENDER acceleration)\n");
> > > pExaScr->info->CheckComposite = NULL;
> > > pExaScr->info->PrepareComposite = NULL;
> > > }
> > >
> > > That's broken. xf86IsOptionSet()'s return value is TRUE if the option
> > > is specified in xorg.conf, whether it's set to true or false. I believe
> > > this should use xf86ReturnOptValBool() or xf86GetOptValBool().
> >
> > Right. Option "Enable" "false" not working in the Monitor section may be
> > due to the same or a similar reason. Julien, do you feel like going
> > through the xserver tree and fixing these kinds of bugs? :)
> >
> All uses of this function were in hw/xfree86/common/xf86Config.c (where
> it's used correctly), hw/xfree86/xaa/xaaInitAccel.c and
> hw/xfree86/exa/examodule.c. The attached patches should fix the bug in
> xaa and exa. Mind to have a look? :)
They look good to me. Can you push them upstream yourself?
Thanks,
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
