On Tue, 14 Feb 2017 14:13:30 +0100 Andreas Boll <andreas.boll....@gmail.com> wrote: > This change has been reverted for stretch. Reopening.
Just tried re-enabling it and it fails to build with weston 4.0.0 and freerdp2-dev 2.0.0~git20180411.1.7a7b1802+dfsg1-2: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./libweston -I./libweston -I./clients -I./tests -I./shared -I./protocol -DLIBWESTON_MODULEDIR=\"/usr/lib/x86_64-linux-gnu/libweston-4\" -DLIBEXECDIR=\"/usr/lib/weston\" -DBINDIR=\"/usr/bin\" -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/pixman-1 -I/usr/include/freerdp2/ -I/usr/include/winpr2 -Wall -Wextra -Wno-unused-parameter -Wno-shift-negative-value -Wno-missing-field-initializers -g -fvisibility=hidden -Wstrict-prototypes -Wmissing-prototypes -Wsign-compare -g -O2 -fdebug-prefix-map=/build/weston-4.0.0=. -fstack-protector-strong -Wformat -Werror=format-security -c libweston/compositor-rdp.c -fPIC -DPIC -o libweston/.libs/rdp_backend_la-compositor-rdp.o libweston/compositor-rdp.c: In function 'rdp_peer_refresh_rfx': libweston/compositor-rdp.c:193:7: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bpp'; did you mean 'bmp'? cmd->bpp = 32; ^~~ bmp libweston/compositor-rdp.c:194:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'codecID' cmd->codecID = peer->settings->RemoteFxCodecId; ^~ libweston/compositor-rdp.c:195:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'width' cmd->width = width; ^~ libweston/compositor-rdp.c:196:7: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? cmd->height = height; ^~~~~~ destRight libweston/compositor-rdp.c:219:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapDataLength' cmd->bitmapDataLength = Stream_GetPosition(context->encode_stream); ^~ libweston/compositor-rdp.c:220:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapData' cmd->bitmapData = Stream_Buffer(context->encode_stream); ^~ libweston/compositor-rdp.c: In function 'rdp_peer_refresh_nsc': libweston/compositor-rdp.c:250:7: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bpp'; did you mean 'bmp'? cmd->bpp = 32; ^~~ bmp libweston/compositor-rdp.c:251:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'codecID' cmd->codecID = peer->settings->NSCodecId; ^~ libweston/compositor-rdp.c:252:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'width' cmd->width = width; ^~ libweston/compositor-rdp.c:253:7: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? cmd->height = height; ^~~~~~ destRight libweston/compositor-rdp.c:259:7: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'width' cmd->width, cmd->height, ^~ libweston/compositor-rdp.c:259:21: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? cmd->width, cmd->height, ^~~~~~ destRight libweston/compositor-rdp.c:261:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapDataLength' cmd->bitmapDataLength = Stream_GetPosition(context->encode_stream); ^~ libweston/compositor-rdp.c:262:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapData' cmd->bitmapData = Stream_Buffer(context->encode_stream); ^~ libweston/compositor-rdp.c: In function 'rdp_peer_refresh_raw': libweston/compositor-rdp.c:299:7: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bpp'; did you mean 'bmp'? cmd->bpp = 32; ^~~ bmp libweston/compositor-rdp.c:300:5: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'codecID' cmd->codecID = 0; ^~ libweston/compositor-rdp.c:306:6: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'width' cmd->width = rect->x2 - rect->x1; ^~ libweston/compositor-rdp.c:308:72: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'width' heightIncrement = peer->settings->MultifragMaxRequestSize / (16 + cmd->width * 4); ^~ libweston/compositor-rdp.c:316:12: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? cmd->height = (remainingHeight > heightIncrement) ? heightIncrement : remainingHeight; ^~~~~~ destRight libweston/compositor-rdp.c:318:36: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? cmd->destBottom = top + cmd->height; ^~~~~~ destRight libweston/compositor-rdp.c:319:10: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapDataLength' cmd->bitmapDataLength = cmd->width * cmd->height * 4; ^~ libweston/compositor-rdp.c:319:34: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'width' cmd->bitmapDataLength = cmd->width * cmd->height * 4; ^~ libweston/compositor-rdp.c:319:49: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? cmd->bitmapDataLength = cmd->width * cmd->height * 4; ^~~~~~ destRight libweston/compositor-rdp.c:320:10: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapData' cmd->bitmapData = (BYTE *)realloc(cmd->bitmapData, cmd->bitmapDataLength); ^~ libweston/compositor-rdp.c:320:44: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapData' cmd->bitmapData = (BYTE *)realloc(cmd->bitmapData, cmd->bitmapDataLength); ^~ libweston/compositor-rdp.c:320:61: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapDataLength' cmd->bitmapData = (BYTE *)realloc(cmd->bitmapData, cmd->bitmapDataLength); ^~ libweston/compositor-rdp.c:323:31: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? subrect.y2 = top + cmd->height; ^~~~~~ destRight libweston/compositor-rdp.c:324:56: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'bitmapData' pixman_image_flipped_subrect(&subrect, image, cmd->bitmapData); ^~ libweston/compositor-rdp.c:329:31: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? remainingHeight -= cmd->height; ^~~~~~ destRight libweston/compositor-rdp.c:330:19: error: 'SURFACE_BITS_COMMAND {aka struct _SURFACE_BITS_COMMAND}' has no member named 'height'; did you mean 'destRight'? top += cmd->height; ^~~~~~ destRight make[2]: *** [Makefile:5531: libweston/rdp_backend_la-compositor-rdp.lo] Error 1 Emilio