Your message dated Wed, 28 Oct 2015 15:44:27 +0000 with message-id <e1zrstn-0002bb...@franck.debian.org> and subject line Bug#686627: fixed in xinput 1.6.2-1 has caused the Debian Bug report #686627, regarding xinput: segfault with just "xinput enable" or "xinput disable" to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 686627: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686627 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: xinput Version: 1.6.0-1 Severity: normal Tags: patch upstream Dear Maintainer, when calling either xinput disable or xinput enable, the result is a Segmentation Fault. The attached patch shows a short usage information for those subcommands instead. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages xinput depends on: ii libc6 2.13-35 ii libx11-6 2:1.5.0-1 ii libxext6 2:1.3.1-2 ii libxi6 2:1.6.1-1 ii libxinerama1 2:1.1.2-1 ii libxrandr2 2:1.3.2-2 xinput recommends no packages. xinput suggests no packages. -- no debconf information>From 0a86b052433dafd58c539b845640ac2e34c7053d Mon Sep 17 00:00:00 2001 From: Timo Paulssen <timona...@perpetuum-immobile.de> Date: Tue, 4 Sep 2012 02:39:44 +0200 Subject: [PATCH] don't segfault on dis/enable without argument. --- src/property.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/property.c b/src/property.c index 14e4308..0f4f7e1 100644 --- a/src/property.c +++ b/src/property.c @@ -827,12 +827,20 @@ int set_prop(Display *display, int argc, char *argv[], char *name, int disable(Display *display, int argc, char *argv[], char *name, char *desc) { + if (argc < 1) { + fprintf(stderr, "Usage: xinput %s %s\n", name, desc); + return EXIT_FAILURE; + } char *new_argv[3] = { argv[0], "Device Enabled", "0" }; return set_prop(display, 3, new_argv, name, desc); } int enable(Display *display, int argc, char *argv[], char *name, char *desc) { + if (argc < 1) { + fprintf(stderr, "Usage: xinput %s %s\n", name, desc); + return EXIT_FAILURE; + } char *new_argv[3] = { argv[0], "Device Enabled", "1" }; return set_prop(display, 3, new_argv, name, desc); } -- 1.7.10.4
--- End Message ---
--- Begin Message ---Source: xinput Source-Version: 1.6.2-1 We believe that the bug you reported is fixed in the latest version of xinput, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 686...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Julien Cristau <jcris...@debian.org> (supplier of updated xinput package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 28 Oct 2015 15:14:22 +0000 Source: xinput Binary: xinput Architecture: source Version: 1.6.2-1 Distribution: unstable Urgency: medium Maintainer: Debian X Strike Force <debian-x@lists.debian.org> Changed-By: Julien Cristau <jcris...@debian.org> Description: xinput - Runtime configuration and test of XInput devices Closes: 686627 Changes: xinput (1.6.2-1) unstable; urgency=medium . * Team upload. * New upstream release. + Fix crash for enable/disable without a device argument (closes: #686627) * Let uscan verify tarball signatures. * Bump Standards-Version to 3.9.6 and update Vcs-* control fields. Checksums-Sha1: cbe952ee18ea62613f2e1d494b73480f678aba43 1922 xinput_1.6.2-1.dsc c3bdd9c39a0d30db8948ae5e8a1354e6b4e9640a 200635 xinput_1.6.2.orig.tar.gz feabfd50ff719bc3015ca5a8f69ec0a0f3fb84cd 5064 xinput_1.6.2-1.diff.gz Checksums-Sha256: e136ff66cccd2760181e31a2d7b5f97384c8f90cd83164374860e97809c7f299 1922 xinput_1.6.2-1.dsc 2c8ca5ff2a8703cb7d898629a4311db720dbd30d0c162bfe37f18849a727bd42 200635 xinput_1.6.2.orig.tar.gz 3f3c5e50b22ca281ba26e48a6607073e310f3534b7a31b5920b574ab7d52a5be 5064 xinput_1.6.2-1.diff.gz Files: 3464b7e4d5a79afad079dc09cb31957e 1922 x11 optional xinput_1.6.2-1.dsc 6684f6015298d22936438173be3b7ef5 200635 x11 optional xinput_1.6.2.orig.tar.gz 3d2aa98bb42ac3fcfb5968a3ba1d543b 5064 x11 optional xinput_1.6.2-1.diff.gz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJWMOekAAoJEDEBgAUJBeQM6UwQAKdV+ecudkpyX6Wrr2o3Wbet XG/+YnyUvvPR5Xx8/BZbUsD7kHmSFCxWI4Wou+y2hqFxz+nV4/lyCx8lauy9qnjs hFL2U4rzWkSBB169FyKSfmgNoLGTv2uQlGDqSfXBABFjidblPxCaGpeE4S0IHpAy +t0OjHu94N8RBrkIUGhtxVD+ZdTeA9Ch+9GITLbA6JTjDBYoIvJKMQ+ZklX5zNpF WUP/4HQVU8OCh8RwH+caYkq7WCQ4CFodHQY3GujUBoH9lqRRFpq57MMU9mfBfsv6 pS22csKrm8HOlIjafNaVxLVplQbVR/f2HNzZu5eDghygYgnW87gkl1j7udmn9Jk1 fdzmw9AS3MQqDr1tn4xJZSsKH5txMT6yxZQ2kBGXatR5jSOoAWSKWioYQCyS/8nu 9RuWb0543B3eX5RgTpID7sQU60IP94jhtPgwOE1jx/LKXw+RLloMCLdfUeCb+UiL XiGfHodU/1K1xhgDvI7WRuJ+q7bM15+1SLPx9dM9bsaEVEO2IpLpYFrSR7aFVgFl MRDDIVJxWnhkMPwShHyuVaZc3wQE+xjcHH9tZDozLjysBe78JYTfanMungi5PGLN KOrvFw8QXCe/41IjWOEvaA9Q5EtDeBBaZGb5Vd1y/OQm7LSifmQu1vmbdZ25jV4U K8+FErRBC27IZ8I4WNJU =naVy -----END PGP SIGNATURE-----
--- End Message ---
