On Thu, May 15, 2014 at 14:26:47 +0200, Fabio Pedretti wrote: > It's already specified upstream > --- > debian/rules | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > I think it's better to have it explicitly, though I don't mind too much. However, if we're no longer passing any flags, we don't need to set DEB_C(XX)FLAGS_MAINT_APPEND at all (in the !armhf case).
Cheers, Julien > diff --git a/debian/rules b/debian/rules > index befb011..207f7aa 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -25,15 +25,15 @@ endif > > ifeq (,$(filter $(DEB_HOST_ARCH), armhf)) > buildflags = \ > - $(shell DEB_CFLAGS_MAINT_APPEND=-Wall DEB_CXXFLAGS_MAINT_APPEND=-Wall > dpkg-buildflags --export=configure) > + $(shell DEB_CFLAGS_MAINT_APPEND="" DEB_CXXFLAGS_MAINT_APPEND="" > dpkg-buildflags --export=configure) > else > # Workaround for a variant of LP: #725126 > buildflags = \ > - $(shell DEB_CFLAGS_MAINT_APPEND="-Wall -fno-optimize-sibling-calls" > DEB_CXXFLAGS_MAINT_APPEND="-Wall -fno-optimize-sibling-calls" dpkg-buildflags > --export=configure) > + $(shell DEB_CFLAGS_MAINT_APPEND="-fno-optimize-sibling-calls" > DEB_CXXFLAGS_MAINT_APPEND="-fno-optimize-sibling-calls" dpkg-buildflags > --export=configure) > endif > > buildflags-i686 = \ > - $(shell DEB_CFLAGS_MAINT_APPEND="-Wall -march=i686" > DEB_CXXFLAGS_MAINT_APPEND="-Wall -march=i686" dpkg-buildflags > --export=configure) > + $(shell DEB_CFLAGS_MAINT_APPEND="-march=i686" > DEB_CXXFLAGS_MAINT_APPEND="-march=i686" dpkg-buildflags --export=configure) > > # keep a list of files we don't install (yet), but since it's a bit > # large, use an external file: > -- > 1.9.1 > > > -- > To UNSUBSCRIBE, email to debian-x-requ...@lists.debian.org > with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org > Archive: > https://lists.debian.org/1400156808-7653-4-git-send-email-fabio....@libero.it >
signature.asc
Description: Digital signature
