Your message dated Sun, 08 Sep 2013 15:51:24 +0000
with message-id <e1vihgm-00019o...@franck.debian.org>
and subject line Bug#657215: fixed in x11proto-video 2.3.2-1
has caused the Debian Bug report #657215,
regarding x11proto-video-dev: sizeof(xvEncodingInfo) vs sz_xvEncodingInfo
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
657215: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=657215
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: x11proto-video-dev
Version: 2.3.1-2
Severity: normal
File: /usr/include/X11/extensions/Xvproto.h
The program foo.c below with gcc 4.6.1-3 prints
sizeof(xvEncodingInfo) 24
sz_xvEncodingInfo 20
where if I'm not mistaken the two are supposed to be equal.
It looks like in the xvEncodingInfo the xvRational field is padded onto
a 4-byte boundary so
CARD32 encoding
CARD16 name_size
CARD16 width
CARD16 height
<compiler padding 16>
INT32 rate.num
INT32 rate.den
CARD16 pad
<compiler padding 16>
= 24 bytes
Perhaps since the rate is 2*INT32 the pad was always supposed to be
before, as
typedef struct {
XvEncodingID encoding B32;
CARD16 name_size B16;
CARD16 width B16, height B16;
CARD16 pad B16;
xvRational rate;
} xvEncodingInfo;
The server circa 1.7.7 seems to spit out 20 bytes in that form. If I'm
not mistaken it uses sz_xvEncodingInfo rather than sizeof, so quietly
ignores the "pad" field at the end. Eg. reply from QueryEncodings
0000000: 01d9 0600 0700 0000 0100 d7bf 8243 0708 .............C..
0000010: 0000 0000 e63f 0d01 0000 0000 e43f 0d01 .....?.......?..
0000020: 0000 0000 0800 fe07 fe07 0d01 0100 0000 ................
0000030: 0100 0000 5856 5f49 4d41 4745 ....XV_IMAGE
The xlib XvQueryEncodings() looks like it uses sz_xvEncodingInfo too,
but I don't have anything with more than one encoding to try to provoke
it.
Presuming what the server sends is correct (or at least is much too late
to change now :-) then perhaps it'd be worth moving the "pad" field to
where it is actually in effect, making the struct size match what's
sent.
Dunno if that would have to rate as a break of binary compatibility.
Presumably yes strictly speaking if anyone exposed that struct in their
interface, but in practice I expect no if it's only ever meant as a
temporary to layout data on send or receive.
#include <stdio.h>
#include <X11/extensions/Xvproto.h>
int
main (void)
{
printf ("sizeof(xvEncodingInfo) %u\n", sizeof(xvEncodingInfo));
printf ("sz_xvEncodingInfo %u\n", sz_xvEncodingInfo);
return 0;
}
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (990, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-5-486
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: x11proto-video
Source-Version: 2.3.2-1
We believe that the bug you reported is fixed in the latest version of
x11proto-video, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 657...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julien Cristau <jcris...@debian.org> (supplier of updated x11proto-video
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 08 Sep 2013 17:16:24 +0200
Source: x11proto-video
Binary: x11proto-video-dev
Architecture: source all
Version: 2.3.2-1
Distribution: unstable
Urgency: low
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Julien Cristau <jcris...@debian.org>
Description:
x11proto-video-dev - X11 Video extension wire protocol
Closes: 657215
Changes:
x11proto-video (2.3.2-1) unstable; urgency=low
.
* New upstream release
+ correct sizeof(xvEncodingInfo) (closes: #657215)
* Bump debhelper compat level to 7, use dh_prep.
* Don't require fakeroot for d/rules clean.
* Bump standards-version to 3.9.3 (no changes needed).
* Remove Andres and David from Uploaders.
Checksums-Sha1:
96dbd8a20445d9404903e7fdda650975c69cf0c3 1941 x11proto-video_2.3.2-1.dsc
a745f8441c3d93ac90249a3ffd6604dc8db3a497 145538
x11proto-video_2.3.2.orig.tar.gz
a60570026cc6dcc5499d334e44744c092dee1164 15893 x11proto-video_2.3.2-1.diff.gz
bfe82704342f576f50fe0b478a49f9dbcbe8ce8f 20920
x11proto-video-dev_2.3.2-1_all.deb
Checksums-Sha256:
b280bd7724f7d8d27a52afc5caab148730fada87dc6b39c501ee2a15a7031f36 1941
x11proto-video_2.3.2-1.dsc
70eaa52beb83d07b71d81b9e4a396ba53c825472c4998f9e7b9889325b2a4346 145538
x11proto-video_2.3.2.orig.tar.gz
01499740e5bb441067ca35998356b080479c071fa8c1906335b2dbe4d8d4016b 15893
x11proto-video_2.3.2-1.diff.gz
83a3a58631a7c2f9cb13ff41c420980c98b030cdfb295e97e50fffe9f25d4511 20920
x11proto-video-dev_2.3.2-1_all.deb
Files:
54227fba5f5664cdaaf775870630a6be 1941 x11 optional x11proto-video_2.3.2-1.dsc
c4e608c52d9ec450aca8b9827fdf51ba 145538 x11 optional
x11proto-video_2.3.2.orig.tar.gz
06fc0b3b0f3c66d3268d6ff4400bfb00 15893 x11 optional
x11proto-video_2.3.2-1.diff.gz
f6fa6f587706f609f8e55384abc23027 20920 x11 optional
x11proto-video-dev_2.3.2-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJSLJUUAAoJEDEBgAUJBeQMidsP/3JUI21sE4o0ndmJaVYJahZp
QHozV8kF2dPXi52/ShBsxjOWm5LGNjuIXnsWTpKRSyWPkyci14xkhKBdLCN6b3PF
xaGB0GWLB74TvT3IESMGst+ns1PLCSiYON4wNVeRIJCK41J+6BWnD9854d0CCCD9
3SEZPdvlWagKBwsFBeC22bLnCYoiuNhR3QNO5ASKW6drD9g0K/qq1hIhCXdehObw
FfBl+N1zL3JkJwC4Z0/DyCrUL6FzNlBinEEEgHyNyUloJQVVTxwHEh2YsHmgFrT/
FLyU7EviZtM8LWToHcdCU14fiC+FemfqSMJJkyzkjLKS+QhjeSuEsSFfcyllsVY7
W9RNudGRRyWV3Ns2Z/DZXEjBoI4NXJNofWufyIvIubM+gcVunxGR+Qc9oRpPRMZv
jQeQs2qrWpwhXWrio9hJwljyFR7IYveN7l+gotufd54iQsJBh+dlufiCJPW9B/hv
ozaAX/ODbfmyflyFvb0Uq/NyCJMz99HUIqBsCBHppdAQcfcFiF1LtvG4aAjC9Kl+
RL2cQveSPSj2FVfD9hLjWfA6rGliqubyN6M9fMyi4JKTeHiDHhQcXvGCECojp1j2
yta153V63pDLbUw4zYV71PhWtmMmQBRbgcqApBsZETDFcSHJwGtd5kMqbBr88jC/
lTlIJV7OZ+SY7sfP17bZ
=+FY0
-----END PGP SIGNATURE-----
--- End Message ---
