Patch #48 in SVN-repository for 4.3.0 not working, replacement attached

[Martin Loschwitz]

Hello Branden, Hello Daniel, hi folks,

With branches/4.3.0/sid/debian/patches/048_radeon_dpms_on_dvi_support.diff,
you have a patch in SVN that aims on getting the "switch-the-backlit-off" 
feature in TFT-panels to work with DPMS on ATI Radeon cards. However, on
my Laptop-TFT, DPMS with 4.3.0-0ds4v2 did not work at all. When DPMS was 
triggered,the image on the screen disappeared but the backlit stayed 
enabled. 

While searching google for the problem, I found a similar bugreport in the
XFree86 bugzilla. There was also a patch attached to this bugreport. I
recompiled Daniel's packages with the old patch #48 removed but the new
one from XFree86-Bugzilla attached and they seem to work perfectly with
the patch.

I would love to see the patch #48 which is in repository right now to
be replaced with the attached patch.

Best regards and thank you for your wonderful work.

-- 
  .''`.   Martin Loschwitz           Debian GNU/Linux developer
 : :'  :  [EMAIL PROTECTED]        [EMAIL PROTECTED]
 `. `'`   http://www.madkiss.org/    people.debian.org/~madkiss/
   `-     Use Debian GNU/Linux 3.0!  See http://www.debian.org/

diff -ruN xc.old/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c 
xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c
--- xc.old/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c      2003-02-25 
04:50:15.000000000 +0100
+++ xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c  2003-06-14 
16:25:42.000000000 +0200
@@ -6523,6 +6523,14 @@
            else {
                if (info->Clone)
                    OUTREGP(RADEON_CRTC2_GEN_CNTL, 0, ~mask2);
+               if (info->DisplayType == MT_LCD) {
+                   usleep(RADEONPTR(pScrn)->PanelPwrDly * 1000);
+                   OUTREGP (RADEON_LVDS_GEN_CNTL, (RADEON_LVDS_ON | RADEON_LVDS_BLON),
+                            ~(RADEON_LVDS_ON | RADEON_LVDS_BLON));
+               } else if (info->DisplayType == MT_DFP) {
+                   OUTREGP (RADEON_FP_GEN_CNTL, RADEON_FP_FPON | RADEON_FP_TMDS_EN, 
+                            ~(RADEON_FP_FPON | RADEON_FP_TMDS_EN));
+               }
                OUTREGP(RADEON_CRTC_EXT_CNTL, 0, ~mask1);
            }
            break;
@@ -6569,6 +6577,12 @@
                if (info->Clone)
                    OUTREGP(RADEON_CRTC2_GEN_CNTL, mask2, ~mask2);
                OUTREGP(RADEON_CRTC_EXT_CNTL, mask1, ~mask1);
+               if (info->DisplayType == MT_LCD) {
+                   usleep(RADEONPTR(pScrn)->PanelPwrDly * 1000);
+                   OUTREGP (RADEON_LVDS_GEN_CNTL, 0, ~(RADEON_LVDS_ON | 
RADEON_LVDS_BLON));
+               } else if (info->DisplayType == MT_DFP) {
+                   OUTREGP (RADEON_FP_GEN_CNTL, 0, ~(RADEON_FP_FPON | 
RADEON_FP_TMDS_EN));
+               }
            }
            break;
        }

pgp00000.pgp
Description: PGP signature