Bug#700570: www.debian.org: people page shouldn't link qa page for missing emails

[Olivier Berger]

Package: www.debian.org
Severity: minor
Tags: patch

Hi.

In the devel/people page, there are entries for developers who are listed in 
the LDAP as having a homepage even though they don't maintain packages.

This could be OK, even though I'm not sure of the intent... maybe to 
acknowledge non-packaging members... but anyway, that's not the issue.

The issue is that the script manages them by not setting an email, in which 
case, the qa links are incorrect.

Here's a patch that fixes this.

IMHO, it would be better, to list them with their email, and flag them in 
another way, so that no package list is processed.

Hope this helps.

Best regards,

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (900, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

>From 33221ab8f32820294d53e9820d3d88f97eb602a2 Mon Sep 17 00:00:00 2001
From: Olivier Berger <olivier.ber...@telecom-sudparis.eu>
Date: Thu, 14 Feb 2013 13:37:10 +0100
Subject: [PATCH] Don't display the QA page link if no email set


Signed-off-by: Olivier Berger <olivier.ber...@telecom-sudparis.eu>
---
 people_scripts/people.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/people_scripts/people.pl b/people_scripts/people.pl
index e04bd46..ce138bc 100755
--- a/people_scripts/people.pl
+++ b/people_scripts/people.pl
@@ -57,7 +57,7 @@ sub print_maintainer {
 		print "&nbsp;<a href=\"mailto:$People{$names}{email}\">&lt;$People{$names}{email}&gt;</a>\n";
 	}
 	# create link to QA page
-	if (defined $People{$names}{email}) {
+	if ($People{$names}{email} ne "") {
 		my $qa = join "", $quality_assurance, $People{$names}{email};
 		print "&nbsp;(<a href=\"$qa\">QA page</a>)\n";
 	}
-- 
1.7.10.4