On Wed, Jan 22, 2003 at 10:09:11PM +0100, Josip Rodin wrote:
[...]
> > When under /News/, /events/, and /security/ directories, NOGENERICDEP
> > is set to true in webwml/Makefile.common.
> > So we have to either add $(GETTEXTDEP) to all targets in these
> > directories, or remove this special handling (I did not check whether
> > it is really needed).
>
> NOGENERICDEP is set because all of those pages need to have a dependency on
> news.wml, events.wml or security.wml, respectively.
But you can add these dependencies, see attached patch.
> In this particular case, it seems more like a case of recent_list template
> missing a dependency on the .mo file which contains those two strings.
Huh? recent_list.wml is not generated, why should it depend on other files?
Denis
Index: Makefile.common
===================================================================
RCS file: /cvs/webwml/webwml/Makefile.common,v
retrieving revision 1.73
diff -u -r1.73 Makefile.common
--- Makefile.common 5 Jan 2003 22:50:30 -0000 1.73
+++ Makefile.common 22 Jan 2003 21:47:02 -0000
@@ -76,9 +76,6 @@
ifneq "$(findstring /News/,$(CURDIR))" ""
NOGENERICDEP := true
endif
-ifneq "$(findstring /events/,$(CURDIR))" ""
-NOGENERICDEP := true
-endif
ifneq "$(findstring /security/,$(CURDIR))" ""
NOGENERICDEP := true
endif
Index: english/events/1998/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/events/1998/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- english/events/1998/Makefile 13 May 2001 13:49:53 -0000 1.8
+++ english/events/1998/Makefile 22 Jan 2003 21:47:02 -0000
@@ -11,7 +11,6 @@
# Do Not modify the following lines
index.$(LANGUAGE).html: index.wml $(wildcard [0-9]*\-*.wml)
$(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml
- $(WML) index.wml
%.$(LANGUAGE).html: %.wml $(TEMPLDIR)/past_event.wml
- $(WML) $(<F)
+
Index: english/events/1999/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/events/1999/Makefile,v
retrieving revision 1.6
diff -u -r1.6 Makefile
--- english/events/1999/Makefile 13 May 2001 13:49:53 -0000 1.6
+++ english/events/1999/Makefile 22 Jan 2003 21:47:02 -0000
@@ -11,7 +11,6 @@
# Do Not modify the following lines
index.$(LANGUAGE).html: index.wml $(wildcard [0-9]*\-*.wml)
$(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml
- $(WML) index.wml
%.$(LANGUAGE).html: %.wml $(TEMPLDIR)/past_event.wml
- $(WML) $(<F)
+
Index: english/events/2000/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/events/2000/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- english/events/2000/Makefile 13 May 2001 13:49:53 -0000 1.5
+++ english/events/2000/Makefile 22 Jan 2003 21:47:02 -0000
@@ -13,4 +13,4 @@
index.$(LANGUAGE).html: index.wml $(wildcard [0-9]*\-*.wml)
$(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml
%.$(LANGUAGE).html: %.wml $(TEMPLDIR)/past_event.wml
- $(WML) $(<F)
+
Index: english/events/2001/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/events/2001/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- english/events/2001/Makefile 13 May 2001 14:03:02 -0000 1.2
+++ english/events/2001/Makefile 22 Jan 2003 21:47:02 -0000
@@ -13,4 +13,4 @@
index.$(LANGUAGE).html: index.wml $(wildcard [0-9]*\-*.wml)
$(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml
%.$(LANGUAGE).html: %.wml $(TEMPLDIR)/event.wml
- $(WML) $(<F)
+
Index: english/events/2002/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/events/2002/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- english/events/2002/Makefile 10 Nov 2001 20:17:09 -0000 1.1
+++ english/events/2002/Makefile 22 Jan 2003 21:47:02 -0000
@@ -13,4 +13,4 @@
index.$(LANGUAGE).html: index.wml $(wildcard [0-9]*\-*.wml)
$(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml
%.$(LANGUAGE).html: %.wml $(TEMPLDIR)/event.wml
- $(WML) $(<F)
+
Index: english/events/2003/Makefile
===================================================================
RCS file: /cvs/webwml/webwml/english/events/2003/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- english/events/2003/Makefile 29 Dec 2002 15:29:25 -0000 1.2
+++ english/events/2003/Makefile 22 Jan 2003 21:47:02 -0000
@@ -21,7 +21,6 @@
index.$(LANGUAGE).html: index.wml $(wildcard [0-9]*\-*.wml)
$(TEMPLDIR)/template.wml $(TEMPLDIR)/recent_list.wml
%.$(LANGUAGE).html: %.wml $(TEMPLDIR)/event.wml
- $(WML) $(<F)
%.$(LANGUAGE).ics: %.wml $(ENGLISHSRCDIR)/events/make_ics.pl
$(ENGLISHSRCDIR)/events/make_ics.pl $< $@
