hi again! On Tue, Oct 27, 2009 at 05:06:19PM +0100, Rodolphe Quiedeville wrote: > I'm ready to upload a new version off pgpool2 2.2.5, the files are > available at http://rodolphe.quiedeville.org/pgpool2/ > > If you could have a look at them, I'll upload the package to mentors if > you think the package is ok.
looks good! the only blocker imho:
i don't have much to back this is up, but i have the sneaking suspicion
that libpcp.so.0 is not a properly managed/soname-versioned shared
library.
since there are no development headers nor are other packages expected
to link against it (afaik), i suggest that you move the shared library
to a private directory (/usr/lib/pgpool2 or similar), and make sure that
the binaries' linked RPATH is updated accordingly. this might be as
simple as specifying --libdir to configure.
other comments (not necessarily to fix now but maybe to throw at the BTS
after the package is uploaded):
* port 5433 was already in use on my system (i have multiple pg clusters
running). maybe the init script could give a warning message if it
can figure out that the port is already in use).
* when the daemon dies, it dies semi-silently (the lack of start-stop-daemon
and the pipe to logger is to blame, though i don't know of a better way
to accomplish this with the lack of proper daemonizing/syslogging in the
upstream code).
* debconf prompts for pcp admin user/password would be pretty sweet.
the rest of the issues that i have with it are better addressed upstream
(we could also file+forward bugs for them):
* lack of ssl support in frontend/backend
* lack of built-in syslog support
* improper daemonizing
* the pcp_foo commands leave quite a bit to be desired in terms of usability.
sean
signature.asc
Description: Digital signature
