* Daniel Kahn Gillmor <[EMAIL PROTECTED]> [2007-03-14 17:58]:
> I think i've addressed all these concerns now. i've published 3.01-2
> into my apt repository, for your examination. My powerpc build
> machine is down right now, so 3.01-2 is only published for arm and
> i386 at the moment.
I checked the package and I think that 3.01-2 has release quality. If you
agree, I will upload it to unstable. My comments below are quite minor and
you could implement them in a future version of the package.
> On Wed 2007-03-14 12:49:35 -0400, Rafael Laboissiere wrote:
> > * debian/menu:
> [snip]
>
> Good call. i've created tweak-wrapper as a variant of your
> recommendation. I also linked in tweak-wrapper.1.gz to tweak.1.gz,
> since i don't think it warrants its own man page.
You might implement a "full debhelper" solution by using dh_install and
dh_links in conjunction with debian/install and debian/links (files
attached below). There is an advantage in doing this: if one day you decide
to switch to CDBS, then you could use an almost trivial debian/rules file,
like the one attached below.
> > * Makefile:
> > + [snip] In the meanwhile, you have two options:
> > 1) Use a patch management system (such as dpatch, quilt, or CDBS'
> > simple-patchsys; I prefer the later because I am a CDBS adept).
> > 2) Call make with the appropriate PREFIX and MANDIR settings in the
> > command line
>
> i've gone with option 2, since it seems like the simplest approach for
> a tool that doesn't need patching otherwise.
The variable DESTDIR is set in the command line, but does not appear in
Makefile. You might drop this.
> > + Most of the *.c files, as well as the *.but and *.h files are lacking
> > copyright notice and licensing terms. We can assume that they are the
> > same as in LICENCE, but the Debian standards require that every file
> > must have those. Your package may be rejected due to that. Please,
> > ask the upstream author to fix this.
>
> I spoke with Simon about this via e-mail, and he's understandably
> reluctant to make changes to 13 files in a relatively small package to
> satisfy a potentially theoretical concern, especially when LICENCE
> seems pretty clear-cut.
I tend to agree with the author and I hope that the ftp-master admin will
not see a problem. We could assume here a "principle of least effort" (or
whatever), meaning that if a file is lacking the licensing terms, then the
ones in LICENCE apply to it.
> Can you give me a reference to policy which states that *every* file must
> include a copyright notice and licensing information?
Look, for instance, at the text of the GPL, around this excerpt:
How to Apply These Terms to Your New Programs
[snip]
To do so, attach the following notices to the program. It is safest to
attach them to the start of each source file to most effectively convey
the exclusion of warranty; and each file should have at least the
"copyright" line and a pointer to where the full notice is found.
> I made one other change: i included Simon's generated btree.html in
> docs/, since it seems relevant, small, and unobtrusive.
Good idea. A debian/doc-base entry for it would be useful (see file
attached below).
> I did this, but the .changes file doesn't get published to the apt
> repository via reprepro, afaict. Do you want me to send it on
> separately? Or is it published in some obscure way by reprepro that
> i'm missing?
AFAICT, *.changes files do no appear in APT repositories. They are only
used when uploading package and appear in debian-devel-changes. Anyway, I
do not need your .changes file, since I always build sponsoree packages
before uploading.
One last thing: I was confused when I asked you to add my name to the
Uploaders list. I am just sponsoring the package and am not co-maintaining
it. Please, remove that in a future release of the package.
--
Rafael
debian/tweak-wrapper usr/bin
tweak.1 usr/share/man/man1/tweak-wrapper.1
#!/usr/bin/make -f
# -*- makefile -*-
include /usr/share/cdbs/1/rules/debhelper.mk
include /usr/share/cdbs/1/class/makefile.mk
CFLAGS = -c -g -Wall -O2
DEB_MAKE_INSTALL_TARGET = PREFIX=$(CURDIR)/debian/tweak/usr
MANDIR=$(CURDIR)/debian/tweak/usr/share/man/man1 install
Document: tweak-btree
Title: An Efficient Data Structure For A Hex Editor
Author: Simon Tatham
Abstract: FIXME
Section: technical
Format: html
Index: /usr/share/doc/tweak/btree.html
Files: /usr/share/doc/tweak/btree.html
