mån 2024-11-25 klockan 19:15 -0800 skrev Otto Kekäläinen: > > > If any of you have have spare time, I'd appreciate a review of > > > https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag > > > before I upload. > > > > Looks good to me. > > > > Instead of the patch I would have added in debian/rules: > > > > override_dh_auto_install: > > dh_auto_install -- --no-binaries > > Good idea, this works as well. However I was planning to submit the > patch upstream. Do you agree it would be a good fix upstream to not > build any example binaries unless the build is instructed to do so > with go build --tags=test or something?
Sounds good. The primary reason I prefer to avoid debian/patches/ is that I don't trust myself patching Go code, so it is better if upstream evaluate patches to code. Another solution could be a debian/not-installed file, if you prefer to not override dh_auto_install like the above. This does seems like a common problem though -- some golang-*-dev upstream's provide some test or debugging binary that is of very rare use, and if your approach helps to avoid them getting into /usr/bin of Debian that sounds like something we should consider more. I'll see if I can get a patch like that into upstream's of the golang-*-dev Architecture:any packages I mentioned in another thread. > > I would have added the following at the end of > > golang-github-muesli-mango-pflag-dev's Description: > > > > . > > This package contains the Go development library. > > Updated accordingly. > > > But these are subjective nit-picks, but I wanted to mention it for > > your > > consideration. > > I am glad to get nit-picks so that I get into the correct Go team > habits and ways of packaging right away. Happy to help -- and I appreciate similar nit-picks to my packaging, as I'm still learning how to approach Go packaging in the best way. /Simon
signature.asc
Description: This is a digitally signed message part
