Adam,

One additional comment:

Your source tree contains a debian/files.  This is an autogenerated file 
created  
(and deleted) during build.  Running sbuild removes it, but to be clean you 
should probably remove it from Salsa.

See:

https://www.debian.org/doc/debian-policy/ch-source.html#generated-files-list-debian-files

On Saturday, September 7, 2024 8:02:46 PM MST Soren Stoutner wrote:
> Adam,
> 
> Debian/copyright must specify a license for each entry.  The one for debian/
*
> is missing.
> 
> W: bashbro source: missing-field-in-dep5-copyright License [debian/copyright:
> 10]
> N:
> N:   The paragraph in the machine readable copyright file is missing a field
> N:   that is required by the specification.
> N:
> N:   Please refer to
> N:   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
> N:   details.
> N:
> N:   Visibility: warning
> N:   Show-Always: no
> N:   Check: debian/copyright/dep5
> 
> You can see an example at:
> 
> https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/
copyright?
> ref_type=heads
> 
> 
> You should add the following two lines to debian/control, which specify the
> location of the packaging repository.
> 
> Vcs-Git: https://salsa.debian.org/adanisch/bashbro.git
> Vcs-Browser: https://salsa.debian.org/adanisch/bashbro
> 
> You can see an example at:
> 
> https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/control?
> ref_type=heads
> 
> 
> As the upstream README.md has important information for end users, you might
> want to install it into /usr/share/doc/bashbro.  You can do this by creating 
a
> file named debian/docs and populating it with the single line:
> 
> README.md
> 
> Beyond the files dh_installdocs automatically installs, it will look for 
those
> listed in debian/docs and install them into /usr/share/doc/bashbro.
> 
> 
> This isn’t a problem for the packaging, but the upstream lists version 1.05 
in
> the header.  It is fine to upload the Debian package that way, but you
> probably want to either update the version number in the header with each
> release or remove it.
> 
> On Saturday, September 7, 2024 6:24:14 PM MST Adam Danischewski wrote:
> > Hi Soren,
> > 
> > If you could build it from the current repo that would be great!
> > 
> > If there are any problems please let me know - I'll address them as soon 
as
> > possible.
> > 
> > Thanks,
> > 
> >  +Ad


-- 
Soren Stoutner
so...@debian.org

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to