On Fri, 14 Jun 2024 12:26:49 -0400 Yogeswaran Umasankar <kd8...@gmail.com> wrote:
> Hi, > > I came across your package in mentors, here are my suggestions, > > - Please file a RFS bug report to make it easily visible to mentors. > Instructions in https://mentors.debian.net/sponsors/rfs-howto/ Hi. Please kindly find an RFS at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1072802. It may be curious that its bug number is immediately after this ITP. > - The latest upstream version is 1.9.1. It is highly recommended to keep > the package updated with the latest upstream version. This ensures > benefit from bug fixes and additional features from the upstream. Thanks for notifying. > - debian/copyright in line 7: Include the year(s). Based on the upstream > history (created approximately 7 years ago with the latest update 2 > days ago), ensure the information reflects this. I don't see any clause in the policy that requires including the year, if the original LICENSE file does not. IMO it's impolite to unnecessarily interpret. > - debian/copyright in line 15: Ensure the license entry follows Debian > conventions. Refer: https://ftp-master.debian.org/licenses/ I'm sure this follows Debian conventions: https://codesearch.debian.net/search?q=On+Debian+systems+the+full+text+of&literal=1 > - Include debian/upstream and required files. Refer: > https://wiki.debian.org/debian/upstream. For example, > https://sources.debian.org/src/jquery-caret.js/0.3.1%252Bdfsg.1-3/debian/upstream/ Sure. > - It's not a convention to include ~mentor1 in the version number for > Debian packages meant for mentors. Please remove it from the > debian/changelog. It's a personal preference. > - Consider including a man page for usr/bin/lsix to assist users. Run > lintian on your binary file to check for any issues. It would be great, but the upstream didn't even provide a help message. Time allowing, I'll ask upstream for it. > - I would recommend to include the README.md file in the binary package. > You can achieve this by listing the file in debian/<package>.docs. Sure. > Cheers! > Yogeswaran Thank you. -- Sdrager, Blair Noctis
OpenPGP_0xC21D9AD423A39727.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
