Hi Nilesh, On Thu, Dec 21, 2023 at 11:10:27PM +0530, Nilesh Patra wrote: > On Wed, Dec 20, 2023 at 08:35:38AM +0100, Nicolas Schier wrote: > > Hi, > > > > I've packaged golang-github-google-gnostic-models, and I need a sponsor > > to get it uploaded. The package is a requirement for > > golang-k8s-apimachinery > > (cp. #1012720). > > Few comments: > > * You do not need a separate hand-crafted .install files to install extra > things you need. > Please use DH_GOLANG_INSTALL_EXTRA in d/rules for that. > * The d/copyright should probably mention "Google LLC" instead of "Google > Inc." since that's > what is mentioned in all the source code files. > * Standards version can be updated to 4.6.2 > * README.md as docs can be dropped. In principle no-one would install a lib > package and read the > README. The lib packages in golang are mainly needed for target consumable > binary packages. > > LMK once you address them!
thanks a lot for your review! I fixed all four points (and updated the debian/watch version) so lintian is now completely satisfied. The corresponding fixup commit is pushed to https://salsa.debian.org/go-team/packages/golang-github-google-gnostic-models.git and the prepared source package is uploaded to mentors: dget -x https://mentors.debian.net/debian/pool/main/g/golang-github-google-gnostic-models/golang-github-google-gnostic-models_0.6.8-1.dsc Kind regards, Nicolas (TIL: I should always push 'UNRELEASED' to the git repos as long as the package is not completely reviewed and accepted.)
signature.asc
Description: PGP signature
