On 2023-06-18 05:10, Jeremy Sowden wrote: >>> Yes, absolutely. Apologies for taking three weeks to reply. >>> >>> J. >> >> And I took two days ;)
This time took literally two weeks, haha. Dragged away by $work. > You've gone a for a less elaborate build process for the shared library > than I did: > > > https://github.com/antirez/linenoise/pull/174/commits/ab860406520ad7fc5e7e8e91fcf60cdc43a786f0 > > but that's probably fine. I do have one observation, however. The > shared library should be liblinenoise.so.0.0.0 and there should be two > sym-links: liblinenoise.so.0, which is needed by the library's > dependencies at run-time, and liblinenoise.so which is needed by its > dependencies at build-time. > > I've attached a patch-series with some suggested changes. > > J. I've applied the patches after reading them. It's great to learn from code. OTOH I saw your salsa repo. Since you've done that much I think it's probably better to let you finish it? -- Sdrager, Blair Noctis
OpenPGP_signature
Description: OpenPGP digital signature
