On 2023-01-19, at 22:56:39 +0100, Romain Francoise wrote: > On Thu, Jan 19, 2023 at 7:01 PM Jeremy Sowden <jer...@azazel.net> wrote: > > I've pushed all the work to my repo on Salsa: > > > > https://salsa.debian.org/azazel/shorewall > > > > Do you want to review it before I push to the shorewall-team repo? > > It all looks pretty good to me! In fact, it's a radical improvement > over the previous packaging with seven source packages. > > I've been staring at the diffoscope output for a few hours and I was > wondering why /etc/network/if-down.d/shorewall seemed to disappear in > shorewall-init but that's actually an upstream change from > 5.2.5-beta1. All the other cleanups and changes look sensible to me, > especially the removal of the debconf bits.
Cool. Must play with diffoscope. I was vaguely aware of it, but I don't think I've ever used it. I imagine it would have made comparing the old and new packages easier than the ad hoc methods I have been using. > I have not yet actually tested the packages in my lab but please feel > free to push your changes to the team repo, and I will do the final > testing and upload over the week-end. I can also take care of opening > the bugs to have the previous source packages removed from unstable. All pushed. I made one more change. The Developer's Reference, § 5.6.1, expresses the preference that when new binary packages are added to a source package, it should be uploaded to experimental, so I've updated the version and distribution in the change-log entry accordingly. > Thanks again for the huge amount of work you put in! No problem. I have been tinkering with this for eighteen months on and off, so it will be good to see it in the archive. :) > > The 5.2.8 source package closes the following bugs: > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932473 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956106 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=960211 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971430 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971855 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=986152 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1002852 > > Awesome. > > > In addition, I think these are candidates for manual closure: > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588349 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719810 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928912 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947217 > > Yup. You already marked #928912 as fixed, so nothing more to do there. I'll start updating the others over the week-end. J.
signature.asc
Description: PGP signature
