On Mon, Apr 27, 2020 at 09:07:36AM +0200, Sébastien Delafond wrote:
> I've pushed my version of restinio's packaging to
> [..]
> Let me know if you want me to upload what I've got now to NEW.
amazing. thank you.
> So we don't forget, here are a couple of items we'll want to fix later
> on:
>
> - salsa-ci
>
> - open an issue upstream to integrate my two cmake patches for the
> scenario "build a release without shipping binaries, yet
> insist on running the tests during our build"
I will see what I can do about these.
Something else that might need work.
The freshly imported tarball (0.6.6) contains an embedded dev/asio
directory, which does not exist in the upstream repository, nor was it
in the 0.6.4 tarball. I understand that this copy is unnecessary. But
some test is compiled with -I${top_srcdir}/dev/asio/include.
The embedded asio does not coincide with libasio-dev in sid, 1:1.12.2-1.
Imo (and I am certainly clueless here) this may lead to questionable
test results. Technically, We may need to depend on a specific
libasio-dev.
cheers
felix
