Hi Jesper, Am Samstag, 2. November 2019 schrieb Jesper Mejervik Derander: > > Hi Mike, > > Thank you for a detailed review! > > > Hi Jesper, > > (Cc:ing Martin Wimpress from Ubuntu MATE) > > > > > > > I'm ok with that. Thank you for taking your time, I will do my best to > > > help. I've applied some upstream patches that fix > > > the manpage issue and i've also taken care of the lintian issues. > > > looking forward to hearing your review comments soon! > > > > Here comes the review: > > > > 1. > > src:pkg name: upstream names it gnome-firmware-updater, so why do you > > name it gnome-firmware > > > > 2. > > bin:pkg name: same as with src:pkg name > > > > 3. > > debian/control: > > > > - SYNOPSIS: gtk front end for fwupd -> GTK > > - LONG_DESCRIPTION: indent the itemizations by two characters > > - LONG_DESCRIPTION: why don't you use the wording from > > upstream's README.md file? Please do. > > > > https://gitlab.gnome.org/hughsie/gnome-firmware-updater/blob/master/README.md > > - Build-Depends: please add a comma after the last pkg name, it > > makes diffs look nicer > > one the line below Build-Depends gets changed (e.g. with another pkg > > name) > > - Vcs-*: fields are missing, we should put the pkg on salsa under > > the debian/ folder > > - Depends: field, I recommend having one package per row. > > - Please use appropriate upper case and lower case letters > > > > debian/copyright: > > > > - personally, I don't like the "Files: *" debian/copyright style, > > but ftpmaster > > wave it through, so... > > - Source: field: no URL with a release number here, I'd put the > > releases/ folder > > here as URL or even better, the GitLab repo. > > > > A general thing: you did good, but for other packages you might > > maintain... I normally > > use all licenses appearing in the upstream code for debian/. > > > > > > debian/changelog: > > > > - my spelling: "Initial release to Debian. (Closes: #941016)." > > -> thus, using full-stops > > > > 4. > > The pristine-tar branch is not on salsa, I cannot build without that > > branch using gbp-buildpackage. > > > > There are three options now: > > > > (a) you work on those bits and pieces and I take a second look > > (b) you are ok with me adding some commits > > (c) a mixture of (a) and (b) > > > > We should created an empty Git repo (gnome-firmware-updater) under > > salsa.debian.org/debian (I can do that, if you agree) and push a clone > > of your Git repo there. Please let me know if you are ok with > > continueing using that repository as the official packaging VCS > > location. > > > > Another option would be placing the packaging Git repo onto the Debian > > GNOME team's namespace on GitLab, but gnome-firmware-updater has > > "gnome" in its name, but as I learned from upstream, it is a suitable > > add-on tool for all GTK-based desktop environments, so a "neutral" > > spot like the /debian team folder salsa is probably the better way to > > go. > > > > Also, Martin Wimpress from Ubuntu MATE and I would like to add > > ourselves as uploaders. Furthermore, I recommend adding the Debian > > GNOME team and the Debian+Ubuntu MATE team as uploaders, too. In old > > times, most Debian packages had been 1-person-maintained, which turned > > out to be a bad concept in case devs went missing in action (MIA). > > Allowing team uploads to packages makes Debian a much more flexible > > place to be at. Please let me know, if you are ok with this, too. > > > > Thanks for your work! > > Mike > > Regarding the naming of the package, I've based it on the Fedora/openSUSE > package and this upstream commit: > https://gitlab.gnome.org/hughsie/gnome-firmware-updater/commit/55705a55e930e4ecb14fc5ae122bbbad9042f03b
Ah, ok. Your package name makes more sense, then. > It seems like this is the current and future package name so I suggest > keeping it. Yes. > If you're okay with it, I'd be happy to take the time and fix these issues > myself, that way I can learn how to do these > things properly (so, option a). I'll try to do it as soon as possible. Ok, please do, then. Thanks! > I'm okay with moving the repo under /debian/gnome-firmware but perhaps I > could tidy up a bit first. I plan to use the > dep14 structure like they do with the gnome-shell package. Perhaps we can > move it after the initial packaging is complete? Yes. Ok. > Are you okay with having a second look once I have a new revision ready? Yes, ping for the next review iteration. Thanks. > I'll let you know when it's done. I'll make sure > to add you and Martin as uploaders by then. Great! > Best regards, > Jesper Derander > light+love Mike -- Gesendet von meinem Fairphone2 (powered by Sailfish OS).
