On Fri, Sep 21, 2018 at 04:15:21PM -0400, Antoine Beaupré wrote: > On 2018-09-17 22:40:10, Nicholas D Steeves wrote: > > Re: a couple of markdown-toc bugs: > > > > https://github.com/ardumont/markdown-toc/issues/29 > > * Solve in Debian with a hard depends on >= markdown-mode 2.2? > > * You mentioned markdown-mode 2.1 is bad, 20161222.1416 is good, > > and 2.2 is from 20170526, thus 2.2 should be good. > > * possibly fixed in markdown-toc? > > I can't reproduce this with the markdown-mode version in Debian. It > might still occur with the version in stable, but then the bugfix is > just an upgrade away.
Cool. And I've patched in a hard ELPA dep on 2.2 so anyone who bpos or installs the unstable dep to stable will have a hint about what's going wrong. Sounds like it will be automatically dropped with the next upstream release :-) > > https://github.com/ardumont/markdown-toc/issues/15 > > * "Don't assume that a document has an h1" > > * How serious is this one? Seems like it could be annoying. > > I just tested this and can confirm the bug happens with your version of > the package as well. > > It's not a big deal: the generated TOC can be modified by hand so extra > content or errors can be easily fixed. In fact, I very often tweak the > TOC by hand myself because it's easier than changing the settings > (e.g. to remove a subsection and so on). Thank you for confirming this one, and that confirming it's not a big deal. > > https://github.com/ardumont/markdown-toc/issues/35 > > * "Lines starting with # in code sections are treated as headings" > > * I imagine this one will frustrate many users. > > I can't reproduce this one, but this may be because of the version of > markdown.el in Debian (2.3snapshot154). Interesting! I'm happy to hear that, and I'll add a manual hard dep (for the next release) on >=2.3snapshot154 for the potential benefit of anyone installing this package to stable. 'just a "nice to have" thing, you know? > So, conclusion: I'd be happy to sponsor the package as is any time. Just > let me know when you're ready and let's get this one out the door! Sweet. Thank you for also addressing the two points I mentioned on #debian-emacs. I've already finalised the changelog. Ready to sponsor from git or mentors. git clone g...@salsa.debian.org:emacsen-team/markdown-toc-el.git # gbp will get orig tarball from upstream tag # alternatively: git deborig dget https://mentors.debian.net/debian/pool/main/m/markdown-toc-el/markdown-toc-el_0.1.2-1.dsc Cheers, Nicholas
signature.asc
Description: PGP signature
