Hi Muri Nicanor,
On Sun, 23 Jul 2017 18:27:13 +0000 Scott Kitterman <deb...@kitterman.com> wrote:
>
>
> On July 23, 2017 12:22:20 PM EDT, Muri Nicanor <m...@immerda.ch> wrote:
> >hi,
> >
> >On 07/23/2017 05:31 PM, Scott Kitterman wrote:
> >>
> >>
> >> On July 23, 2017 11:07:47 AM EDT, Muri Nicanor <m...@immerda.ch>
> >wrote:
> >[...]
> >>> - this is a dependency of errbot (see #803347)
> >>> - i plan to build the initial package myself and then get
> >>> in contact with the python team for RFS and joining or
> >>> handing over the package
> >>
> >> Every package needs a human uploader.
> >which can not be me, i'm not a DM
>
> Uploader in this context (as opposed to Maintainer in debian/control) means
> roughly assist maintainer, not literally person that uploads the package.
> Sorry for not being clear.
>
> >> There is no 'handing over'.
> >sorry for me not being a native speaker, my wording was off, i didn't
> >mean to offend anyone
>
> Not a problem. No offense taken.
>
> >> It looks like this would be reasonable to maintain as part of DPMT,
> >but if you don't plan to keep it updated, don't upload it.
> >i plan to keep it updated
> >
> >cheers,
> >muri
>
> Great.
>
> Scott K
>
O did a review and have some comments. Please do:
- debian/changelog needs an update on timestamp:
- run 'dch -r'
- debian/control:
- add python3-setuptools to Build-Depends
- Standards-Version is 4.1.1
- Depends field: ${python3:Depends} not ${python:Depends}
- Remove ${python:Recommends} and ${python:Suggests} or see the
lintian-info
- Add two more lines on long description. Can be something like:
.
You can use syntactic sugar.
256 RGB colours supported.
. |
This package installs the library for Python 3.
|
- debian/watch:
- the line seems ok, but it is version 4 not 3
- run wrap-and-sort at the end.
Regards,
Herbert
