Thank you for the review!
Dominik George from Debian Edu team agreed to sponsor my package once I
get accepted to Edu team and fix the package problems.
Should I update the RFS somehow to reflect this?
best regards,
Aivar
21.10.2017 03:03 David Steele kirjutas:
On Mon, Oct 16, 2017 at 7:14 AM, Aivar Annamaa
<aivar.anna...@gmail.com <mailto:aivar.anna...@gmail.com>> wrote:
I think I managed to complete the package.
Here is the debian folder:
https://bitbucket.org/plas/thonny-debian/src/master/debian/?at=master
<https://bitbucket.org/plas/thonny-debian/src/master/debian/?at=master>
Here are the resulting files:
https://bitbucket.org/plas/thonny-debian/downloads/
<https://bitbucket.org/plas/thonny-debian/downloads/>
I uploaded the package to https://mentors.debian.net. The output
from dput indicated everything went fine, but I can't see the
package under "My packages". Does it take some time?
I can see the package on mentors. It looks pretty good.
The watch file has some problems. Take a look at a recent uscan man
page for an example of a pypi watch file, and run 'uscan
--force-download --verbose' to test.
I'm a big fan of watch files and of get-orig-source
(https://wiki.debian.org/onlyjob/get-orig-source). The PGP signature
checking capability of uscan is also a good thing, if you are feeling
adventurous.
You still have a lintian issue to deal with Run 'lintian' in the
project directory after a build to review. Debian standards changes
are summarized in
https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt.
I see that the tip of master builds much more cleanly - it needs a
commit tag to match in the changelog.
I built from your repository. There are generally two models for
maintaining packaging git repositories. One way has a branch
containing only a debian directory. The other includes the upstream
data, both in a pristine state, and also included with the debian
directory for building. You've gone the source included route, but the
files don't match the tar downloaded from pypi. Make sure you can
build without error. (Yes, I know the tar probably doesn't match the
upstream repository, but the watch file defines the tar as the
canonical source. Maintain the differences in the debian branch, and
review them).
Remember that, at some point, the UNRELEASED reference in the
changelog needs to change to unstable.
I haven't installed the package yet.
--
AE0D BF5A 92A5 ADE4 9481 BA6F 8A31 71EF 3661 50CE
