On 2017-04-25 18:27:11, Nicholas D Steeves wrote:
> On Tue, Apr 25, 2017 at 01:37:12PM -0400, Antoine Beaupré wrote:
>> On 2017-04-25 11:17:28, Nicholas D Steeves wrote:
>> >
>> > It will take some time to learn how this one works, but another reason
>> > I'm interested in maintaining writegood-mode is I'm certain I can
>> > contribute to it. Preliminary packaging is here:
>> > ssh://git.debian.org/git/pkg-emacsen/pkg/writegood-mode.git
>>
>> Excellent. Same remark than writeroom about uploading to
>> mentors.debian.net. :) But it's great you pushed into git!
>>
>> (It's just that I'm lazy: mentors.debian.net shows lintian output for
>> me... ;))
>
> I've uploaded a package for review. Since I'm still a DM, would you
> please sponsor it if it looks good? I'd be happy to add you to
> uploaders, if you'd like.
>
> https://mentors.debian.net/package/writegood-mode
> dget -x
> https://mentors.debian.net/debian/pool/main/w/writegood-mode/writegood-mode_2.0.2-1.dsc
thanks!
here's a short review.
1. the package's description doesn't mention "emacs" or "english" - in
the original RFP, i used this instead:
Description : Minor mode for Emacs to improve English writing
This is a minor mode to aid in finding common writing
problems. Matt Might’s weaselwords scripts inspired this mode.
.
It highlights text based on a set of weasel-words, passive-voice
and duplicate words.
2. that version patch - really necessary? if upstream screwed up their
versioning, it's kind of their problem no? since it's just a
cosmetic change, I would avoid it, personnally.
3. if you still think it's necessary, explain *why* it is there in the
changelog, not just "it's there". :) same in the patch: not "what"
but "why" in commitlogs...
4. picking a random elpa package (elpa-helm), i notice it depends on
"emacs" while yours depend on "emacs-common" - why? and why the
versioned dependencies?
https://anonscm.debian.org/git/pkg-emacsen/pkg/helm.git/tree/debian/control
I'm not very familiar with "elpa" packages, so I don't know if it works
or not - did you actually test this? :)
Thanks!
A.
--
Never be deceived that the rich will allow you to vote away their wealth.
- Lucy Parsons
