Hi Filip, On Fri, Jan 29, 2016 at 04:13:48PM +0100, Filip Pytloun wrote: > I have prepare khal package: > http://mentors.debian.net/package/khal > > Is there anyone interested in sponsoring it?
I am interested in this package and would like to see it included in Debian. I spent a brief look into it already and found a number of issues: * debian/copyright: The license grant for the MIT license suspiciously looks like a GPL grant and references the non-existent file /usr/share/common-licenses/MIT. * khal.conf.sample should be installed using dh_installexamples instead of dh_installdocs. * Your patches say what they are doing, but the patch headers lack reasoning on why they are necessary (in particular the second patch). * It seems that you are packaging khal as a Python2 application, but upstream only declares it working with Python3. Is there any reason not to use Python3? * Instead of installing the manual page twice, please use a symbolic link. Try using dh_link. At least the copyright issue is a blocker. If you update the package, please Cc me, so I can have another look. Helmut
