On Sat, Jan 18, 2014 at 6:34 AM, Michael Stapelberg <stapelb...@debian.org>wrote:
> Hi Johan, > > Johan Euphrosine <pro...@google.com> writes: > >> Can you please push the forgotten branches/tags? Thanks! > > > > Done (and tested). > Thanks. > PTAL > > A few comments: > • You’ll want to bump debian/compat to 9 since you are requiring > debhelper >= 9 as build-dependency anyways. > Done. > • In debian/copyright, I’d recommend to license debian/ under the same > license that upstream ships with (i.e. BSD-2-clause in this > case). This is to prevent licensing issues when shipping patches in > debian/patches > Done. (thought Apache 2.0 should be compatible with BSD-2-clause?) > • debian/docs is empty, so just delete it? > Done. > • In debian/README.Source, if you want to make it perfect, add git > checkout <revision> to make the instructions easily reproducible. > Done. > Aside from that: > • I’m curious about debian/Dockerfile. What do you use it for? AFAICT, > it “just” builds a package automatically. Apart from the step which > fetches the current upstream source, you can already do that with > gbp-clone and git-buildpackage, right? > I should probably update the Dockerfile to use git-buildpackage instead of debuild, > > -- > Best regards, > Michael > -- Johan Euphrosine (proppy) Developer Programs Engineer Google Developer Relations
