2013/10/31 Nicholas Breen <nbr...@debian.org>: > On Sun, Oct 27, 2013 at 02:55:04PM -0600, Christoph Junghans wrote: >> I finalize found the time to make the first steps to package VOTCA for >> Debian. >> The source/binary builds are available on >> <https://launchpad.net/~ottxor/+archive/votca>. >> >> Please have a look and help me to improve it, so that I can hand it >> over to debichem soon. > > Hi Christoph, > > Thanks for working on those. They look fairly sensible to me; the one change > I'd strongly recommend is updating them to debhelper v9 compatibility, which > should automatically handle both the multiarch paths and appending CPPFLAGS to > CXXFLAGS. It might also be worth specifying what exactly the dh_python2 calls > should operate on, since those throw a lot of errors during their run from > trying (and failing) to operate on non-python files -- not a fatal error, it > just makes that part of the build log hard to read. Don, done & done. VOTCA uses the LIB variable to set the lib location, which is obliviously not what dh excepts, so I left this in rules.
> There's still a second typo in 11_csg_boltzmann_typo.patch: "telp" -> "help" Done. > > Have you considered including the tutorials as additional documentation? I > tried setting those up at first with the multiple-tarballs feature of the 3.0 > source format [1], which does work although you'll need to write your own > installation procedure in debian/rules for them. Done. > > Policy 3.9.5 was just released [2], so you can bump the Standards-Version > lines > in debian/control. I don't see any changes that would affect your packaging. Done. > > -- > Nicholas Breen > nbr...@debian.org > > > [1] > https://wiki.debian.org/Projects/DebSrc3.0#How_to_use_multiple_upstream_tarball_in_3.0_.28quilt.29_format.3F > [2] https://lists.debian.org/debian-devel-announce/2013/10/msg00006.html -- Christoph Junghans Web: http://www.compphys.de -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAHG27e43H1k6ZhukhFMKOcVUYkt6D7tYOQDFuxD=+ls1app...@mail.gmail.com
