On Sun, 26 May 2013 11:02:01 Luke-Jr wrote: > On Saturday, May 25, 2013 11:31:42 PM Dmitry Smirnov wrote: > > Draft packaging is committed to > > > > http://anonscm.debian.org/gitweb/?p=pkg-bitcoin/bfgminer.git > > - There should be no build-depends for OpenCL: BFGMiner includes the official > headers from Khronos, and uses dlopen to avoid any link-time library > dependency. > - The ADL SDK (commented in rules) is not needed or used at all for BFGMiner; > instead, it includes minimal statement-of-fact headers (at least in the US > jurisdiction, not eligible for copyright) I wrote to replace the non-free > dependency. As the ADL library itself (linked with dlopen) is part of the OS > when available, it should fall within the GPL's exception for that.
Thank you for your review. I committed corrections to above issues that were inherited from "cgminer" packaging. > - I am aware of the Ztex copyright issue, have been working to resolve it, > and > expect to have it resolved prior to the next release (soon). Currently, this > is waiting only on a license grant from one minor contributor (the original > author and other contributors to the code in question are agreeable with > GPL-3+ terms). Very well, I hope re-licensing will be successful. Thanks for taking care of that. > - Not familiar with what "libudev-dev [!kfreebsd-any]" does; does it block > packaging on Debian GNU/kFreeBSD? Ideally non-Linux platforms would simply > build without libudev, since it is optional. This is exactly what "libudev-dev [!kfreebsd-any]" do: it pulls "libudev-dev" on all architectures but kFreeBSD (where it is not available) so package won't FTBFS due to missing Build-Dependency and will build successfully on kFreeBSD without "libudev-dev" that is not strictly required. > In fact, on systems with sysfs, I don't believe there is any benefit > to building with libudev at all anymore - so perhaps it should just > be disabled? I have no idea, sorry. This is beyond my level of competence so I have no opinion on this. Regards, Dmitry Smirnov GPG key : 4096R/53968D1B --- The gods offer no rewards for intellect. There was never one yet that showed any interest in it. -- Mark Twain, 1900 -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201305291221.30974.only...@member.fsf.org