Uploaded a version to mentors: https://mentors.debian.net/package/thin-provisioning-tools
On 7 November 2012 17:22, Dmitrijs Ledkovs <x...@debian.org> wrote: > On 18 October 2012 10:59, Neil Wilson <n...@aldur.co.uk> wrote: > > On 17 October 2012 14:01, Dmitrijs Ledkovs <x...@debian.org> wrote: > >> If you have the package ready, I'd be happy to review it and sponsor > >> it. If you need sponsor that is. > > > > I will need a sponsor and reviewer. I haven't done one of these for a > > while so I may be a bit rusty on the latest standards. > > > > I've packaged at https://github.com/NeilW/deb-thin-provisioning-tools > > > > I've improved the description and the only wrinkle from a standard > > autoconf package is that the MANDIR doesn't appear to be set correctly > > in the upstream configure. Hence the alteration to debian/rules. > > > > The package builds and is lintian clean. It should be pretty much ready > to go. > > > > This package does cause issues with the current Debian/Ubuntu lvm2 > > package which are corrected in newer versions of lvm2 upstream. > > > > e.g. > http://git.fedorahosted.org/cgit/lvm2.git/commit/?id=f61cacad1604eaaef18389a46b07e35eb1072008 > > and > > > http://git.fedorahosted.org/cgit/lvm2.git/commit/?id=8db4540263f607e2113a405953000527ffd34b3c > > > > The Red Hat lvm2 package uses --with-thin-check=/usr/sbin/thin_check > > to configure the default to the correct location for the check > > executable. > > > > There are many more patches to the dm thin support code in the lvm2 > > git archive. Are you planning to upgrade the Debian/Ubuntu packages to > > newly released 2.2.98? > > > > Debian is currently frozen. And in Ubuntu I am not planning to go > ahead of Debian (unstable/experimental). > You should talk to Debian lvm2 maintainers to get lvm2 updated in > experimental if that's a pre-requisite for your package. > > I didn't review your package yet. > > While packaging in git is good, can you please generate a debian > source package and upload it into a dgetable location? E.g. > mentors.debian.net ? (that website also checks for common errors ahead > of sponsors). > > Regards, > > Dmitrijs. > -- Neil Wilson
