On 06/14/2012 01:41 AM, Olivier Berger wrote:
> Hi.
>
> I've prepared in :
> http://anonscm.debian.org/gitweb/?p=users/obergix/phpcas.git;h=refs/heads/git-buildpackage%2Bdebpear
Why not using /git/pkg-php instead of your own private Git repo?
> an updated packaging for phpCAS (see also RFP #495542).
>
> phpCAS can be managed as a PEAR package for some time, so I've started
> over previous packaging attemps, using debpear.
>
> I'd appreciate some review, and potential merge requests in order to
> try and upload it soon in time for wheezy.
* Why did you add some debian/{docs,examples,install} files then? If
that's a PEAR package, then the package.xml will reference all of these,
"pear install" called by pkg-php-tools will do the work for you.
* I don't think you need the README.source
* If it's an initial release, please clean-up debian/changelog and have
only one entry there (eg, that last one from this month). You are
documenting what's in Debian, not your own work here.
* I don't believe that the apache-2.0 copyright notice you wrote in
debian/copyright is enough. Shouldn't you write the full text of it?
* Why did you override_dh_auto_install ?
* I don't think that the original long description from the package.xml
is good enough (it's not long enough, Lintian should even complain that
it should be more than 3 lines long). I believe this should be fixed
with something more descriptive (replacing ${phppear:description}).
Also, it'd be great if you could follow the branche naming convention
that I wrote here:
http://pkg-php.alioth.debian.org/
BTW, I have just uploaded a new version of debpear with all of your
suggestions (thanks for them). See "man debpear" on how to do what you
needed, I used php-cas as example in the man page! :)
If it didn't reach your favorite SID repo before you want to try, then
just build v0.2 from /git/pkg-php/debpear.git on Alioth.
Cheers,
Thomas
--
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4fd8ea76.60...@goirand.fr
