Hi, On Mon, May 28, 2012 at 01:52:56PM +0200, Ask Hjorth Larsen wrote: > 2012/5/27 Michael Banck <mba...@debian.org>: > > 1. The changelog entry should not refer to ppa, and should read > > "unstable" as distribution. Â If the package was never in Ubuntu, I would > > also suggest to remove all prior changelog entries and just have one > > entry saying "Initial upload (Closes: #602126)." or so. > > So something like: > > -------------- > python-ase (3.6.0.2515-1) unstable; urgency=low > > * Initial upload (Closes: #602126). > > -- Ask Hjorth Larsen <asklar...@gmail.com> Sun, 27 May 2012 02:32:46 +0200 > ------------- > > Is that okay?
Yeah, that's perfect. > > 2. The copyright information seems to be incomplete, a quick recursive > > grep for "Copyright" in the ase/ directory yields at least CAMP, Jesper > > Friis and Neil Martinsen-Burrell as additional copyright holders. > > I have written a comprehensive copyright file with the full list of > upstream authors (60+), and a precise copyright attribution. > > > 3. io/fortranfile.py also has a BSD-like license which must be added to > > copyright. Â Possibly other files have different copyright as well, I > > have not checked them all. > > A few of the files turned out to have been included from other > projects with slightly different licenses. I have listed all the > licenses and the corresponding files. > > Here is the copyright file as it looks now: > > http://www.student.dtu.dk/~ashj/opendir/ase-debian-copyright > > Does it look acceptable? Wow, big effort! This should be perfectly fine, many thanks. > > Those are suggestions and not required for upload: > > > > 1. It might be a good idea to run testase on package build as well, e.g. > > to catch possible issues with different architectures (a long shot I > > guess, as it seems to be all-python) > > Hmmm. But when building, the package is not installed. So the tests > will not (generally speaking) run without also installing the runtime > dependencies. I guess it is possible to run most of the tests, but > they would have to run from within the build/ directory which only > contains the .py files, since the actual pyc files only exist in the > package. Is there a sort of automatic way to emulate that the package > gets installed, so that the tests can be run in a more straightforward > way? It wouldn't be a problem to add the runtime dependencies as Build-Depends. Whether it is then possible to just run testase I don't know - if not, it might be worthwhile (but not high priority) to fix this. In general, I think it makes sense to run the test suite both directly after building (and before installing), and on the installed package. > > 2. If you want to maintain ASE as part of debichem, you should set > > "Debichem Team <debichem-de...@lists.alioth.debian.org>" as Maintainer > > in debian/control and set yourself as Uploaders: > > The initial idea was for the package to be part of Debian Science. I > don't mind it being part of Debichem. I guess we can change it if > that turns out to be a better idea, but so far I have not changed > this. I don't mind either way. It can be changed later on anyway. > > 3. The patch "debian-changes-3.6.0.2515-1~ppa3" in debian/patches should > > get split up into logical parts with descriptive file names each. > > However, if the next upstream version has this patch anyway, it might > > not be worth the effort. > > Let's save the effort then :) > > > 4. If all the changes mentioned in README.Debian are in the above patch, > > you do not need to mention them there and can delete the file > > Since I refrain from cleaning up the patches, I guess it might be a > good service to let the description stay for now. OK. Just point me at a new source package, once you finalized your changes. Cheers, Michael -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120528171621.gf1...@nighthawk.chemicalconnection.dyndns.org
