Hi Jérémy, thanks for your review.
On Fri, 2011-09-09 at 15:02 +0200, Jérémy Bobbio wrote:
> Here is my review:
>
> * Files in pristine-tar are wrongly named
>
> Trying to build the package with `git-buildpackage
> --git-pristine-tar` fails with:
>
> pristine-tar: git show
> refs/heads/pristine-tar:cookie-monster_1.0.5.orig.tar.gz.delta failed
>
> Indeed. The files are currently named
> `cookie-monster_1.0.5.tar.gz.{delta,id}`.
>
> * dpkg-source: error: unrepresentable changes to source
>
> As upstream does not ship .tar.gz (or .tar.bz2 for that matter) that
> Debian could directly use, we need to create a .orig.tar.gz from
> upstream source.
>
> So we are free to fiddle with upstream source in order to get the
> files as close as we would like upstream to ship them. I then
> strongly advocate to have a .orig.tar.gz where cookiemonster.jar
> is unpacked.
>
> That will also remove the useless patch in debian/patches and ease
> future reviews of upstream changes
Right. I started now from scratch and these problems are solved.
> * Package description could be improved
>
> The package description does not mention that cookie-monster is
> an extension for Firefox/Iceweasel. Please note that
> volunteers subscribed to debian-l10-english@l.d.o can help to
> write better (english) package descriptions.
Added '..an extension for Firefox/Iceweasel' in long description.
> * Package is missing a README.source
>
> Even if it's not mandatory, the package is really missing a
> README.source. It is supposed to be under the pkg-mozext umbrella,
> so other member of that team should be able to upload the package
> if the need arises.
>
> Things that ought to be documented are at least: git-buildpackage
> usage, pristine-tar usage, the upstream-changelog file (why, what and
> how to update it).
Usually I never used, but if necessary I can create it.
>
> * Vcs-* should be updated
>
> Vcs-* field in debian/control should be updated to the new URIs.
Now the Vcs-* fields looks fine.
>
> * Inaccurate copyright file
>
> The copyright file that gets installed in
> /usr/share/doc/xul-ext-cookie-monster/copyright is inaccurate,
> as the MPL license is not copied to the same directory.
I create a new copyright file, hoping this time is right.
Could you please check the package now?
Thank you.
Cheers,
Fabrizio.
signature.asc
Description: This is a digitally signed message part
