On Wed, Jun 08, 2011 at 08:32:17PM -0300, gustavo panizzo <gfa> wrote: > i think the package is ready to be uploaded, i improved Recommends and > fix a lintian warning (newest lintian)
Hi, I reviewed the package last night. Sorry for the long delay. Here's my notes: There are a few lintian warnings. Comments on them: > W: vavoom source: format-3.0-but-debian-changes-patch the file debian/patches/debian-changes-1.32-1 needs renaming to something descriptive and the patch itself documenting (replacing the stuff above the actual patch in the file with a description; ideally filling out some of the example patch description things there). > E: vavoom: helper-templates-in-copyright If you change "Upstream Author(s):" in debian/copyright to "Upstream Author:" you'll get rid of this warning. > W: vavoom: binary-without-manpage usr/games/vlaunch We've already discussed this (not a blocker for initial upload)… but, do you intend to resolve it eventually? Other package comments: > Recommends: > game-data-packager | doom-wad-shareware | doom-wad | doom2-wad | > plutonia-wad | tnt-wad I think this should be something like > Recommends: doom-wad | heretic-wad | game-data-packager because: * if the user satisfies doom-wad or heretic-wad, there's no need for g-d-p * doom-wad is a virtual name provided by *any* doom wad, e.g. plutonia, tnt, doom2, all provide it; so there's no need to enumerate all the concrete names You've joined the games team. Do you intend to maintain this package as part of the team? If so, you should move your name to an Uploaders: header in debian/control and change Maintainer to: > Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org> I would suggest some tweaks and an expansion to the description. * "source port" is a term used inside the doom community which doesn't really make sense outside of it anymore. A better phrase is 'engine'. * you should note you need game data to make use of it (see descriptions of prboom, chocolate-doom for examples) -- Jon Dowland -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110902085220.GA15581@pris
