A new review: There are bound to be more things to fix, I'll do another one when the issues below are resolved.
Hamish, you should add yourself to the Uploaders, or use `dch --team` to indicate a GIS team upload. override_dh_installman shouldn't be needed, best create a debian/opencpn.manpages file listing the manual page. It should probably also reference the HTML documentation in the SEE ALSO section. I personally like to wrap the Build-Depends line one item per line so that changes to them are easier to diff. "cross-platform" isn't relevant in the context of Debian package descriptions. The package descriptions are duplicates of one another. Please see the warzone2100 packages for how I think data package descriptions should look. Why are you depending on libgps19 manually? Dependencies on libraries should only be done via the shlibs mechanism. Your Standards-Version is out of date, please read the upgrading checklist from the version of debian-policy in sid and do any required changes: /usr/share/doc/debian-policy/upgrading-checklist.txt* You can remove the extra whitespace lines at the end of debian/control. No need for the blank line in debian/watch. The watch file doesn't work, please replace it with this: version=3 http://sf.net/opencpn/OpenCPN-(.+)-Source\.tar\.gz I'm not sure what the letters mean in the upstream version numbers but if they mean alpha then I suggest this instead since Debian mainly prefers upstream blessed as stable versions: version=3 http://sf.net/opencpn/OpenCPN-([\d\.]+)-Source\.tar\.gz Please write a get-orig-source debian/rules target since the watch file does not find the tarball for the version listed in debian/changelog. debian/changelog does not close the ITP. The upstream README file contains information about building and dependencies, which is not useful to people installing the binary package. Please get upstream to split that out into README.install so that it can be shipped in the source package but not the binary package. Some of the path names may need tweaking for Debian too (/usr vs /usr/local etc). Please add DEP-3 compliant headers to the patches: http://dep.debian.net/deps/dep3/ Please alter the patches until they are acceptable for and included upstream. plugins/grib_pi/CMakeLists.txt seems to include Windows line endings, eww. I personally use this in my ~/.quiltrc to generate nice looking patches with less cruft: QUILT_REFRESH_ARGS="-pab --no-timestamps --no-index" I personally like to wrap debian/menu one item per line to make diffs easier to read. debian/README.harmonics seems to duplicate data/doc/README.harmonics, please merge the extra info in the debian one upstream. Please add --parallel to the invocation of dh so that opencpn can be built using parallelism. You can drop lines 2-9 from debian/rules (the comments) and the extra whitespace. The xpm file can be installed by dh_install, just edit debian/opencpn.install to add this (you might need to drop the ../../, not sure): ../../src/bitmaps/opencpn.xpm usr/share/pixmaps It would be nice if override_dh_install/override_dh_installdocs wasn't nessecary, please look at sending upstream patches to fix that by offering options to not install stuff, install stuff to the right names and install the plugins in the right dir. When building the package I noticed that the gcc command-lines had both -O2 and -O3. When building twice in a row a new patch is added (debian-changes-2.4.423-1), looks like this is caused by include/version.h not being cleaned up by debian/rules clean, please fix the upstream build system so it does that or add it to debian/clean. Why is the MacOS X icon completely different to the normal OpenCPN logo? Please remove the prebuilt Windows executables from the source tarball and git repository. data/doc/images/print.html seems to be a 404 page, please remove it. data/doc/css/ can probably be used since nothing in the package uses it. Please remove data/doc/js/. Nothing in the package uses it and it is a embedded code copy that is minified and therefore is missing the source code. A lot of the source code contains CVS $Id lines while the package is in git, I would suggest to clean those up, especially the CPL_CVSID ones. The upstream README file (and many other files) has the executable bit set, why is that? The following scripts look like they should be run during the build process so that any changes to the SVG files are reflected in the bitmaps. Alternatively they could be merged into the CMake build system. plugins/grib_pi/src/icons.sh plugins/dashboard_pi/src/icons.sh src/bitmaps/32x32_svg_src/cursor/create_all_32x32.sh src/bitmaps/32x32_svg_src/ribbon/create_all_32x32.sh src/bitmaps/13xX_svg_src/create_all_13xX.sh src/bitmaps/28x28_svg_src/create_all_28x28.sh src/bitmaps/optimize_png.sh src/bitmaps/other_svg_src/create_opencpn_main_icon.sh src/bitmaps/other_svg_src/create_ship.sh src/bitmaps/16x16_svg_src/create_all_16x16.sh src/bitmaps/create_all.sh What is the license for src/bitmaps/paypal_donate.xpm? Lintian complaints: W: opencpn source: changelog-should-mention-nmu W: opencpn source: source-nmu-has-incorrect-version-number 2.4.423-1 W: opencpn: description-synopsis-starts-with-article P: opencpn: no-upstream-changelog E: opencpn: embedded-library usr/bin/opencpn: tinyxml I: opencpn-doc: possible-documentation-but-no-doc-base-registration W: opencpn source: out-of-date-standards-version 3.8.4 (current is 3.9.2) P: opencpn source: source-contains-prebuilt-windows-binary buildwin/NSIS_Unicode/UI/opencpn_ui.exe P: opencpn source: source-contains-prebuilt-windows-binary buildwin/NSIS_Unicode/Plugins/w7tbp.dll P: opencpn source: source-contains-prebuilt-windows-binary buildwin/NSIS_Unicode/Plugins/UAC.dll P: opencpn source: source-contains-prebuilt-windows-binary wxWidgets/wxbase28u_vc_custom.dll P: opencpn source: source-contains-prebuilt-windows-binary buildwin/NSIS_Unicode/Plugins/AccessControlW.dll P: opencpn source: source-contains-prebuilt-windows-binary buildwin/NSIS_Unicode/Plugins/ShellLink.dll P: opencpn source: source-contains-prebuilt-windows-binary wxWidgets/wxbase28u_net_vc_custom.dll P: opencpn source: source-contains-prebuilt-windows-binary buildwin/vc9/vcredist_x86.exe P: opencpn source: source-contains-prebuilt-windows-binary wxWidgets/wxbase28u_xml_vc_custom.dll P: opencpn source: source-contains-prebuilt-windows-binary wxWidgets/wxmsw28u_aui_vc_custom.dll P: opencpn source: source-contains-prebuilt-windows-binary wxWidgets/wxmsw28u_adv_vc_custom.dll P: opencpn source: source-contains-prebuilt-windows-binary buildwin/NSIS_Unicode/nsis-2.46-Unicode-setup.exe P: opencpn source: source-contains-prebuilt-windows-binary wxWidgets/wxmsw28u_core_vc_custom.dll dpkg-shlibdeps warnings: dependency on libz.so.1 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libX11.so.6 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libwx_gtk2u_html-2.8.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn debian/opencpn/usr/lib/opencpn-plugins/libgrib_pi.so debian/opencpn/usr/lib/opencpn-plugins/libdashboard_pi.so" were not uselessly linked against it (they use none of its symbols). dependency on libwx_baseu_xml-2.8.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn debian/opencpn/usr/lib/opencpn-plugins/libgrib_pi.so debian/opencpn/usr/lib/opencpn-plugins/libdashboard_pi.so" were not uselessly linked against it (they use none of its symbols). dependency on libbz2.so.1.0 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libglib-2.0.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libatk-1.0.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libXext.so.6 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libgdk_pixbuf-2.0.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libcairo.so.2 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libpango-1.0.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libSM.so.6 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libfreetype.so.6 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libICE.so.6 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libGL.so.1 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). dependency on libgdk-x11-2.0.so.0 could be avoided if "debian/opencpn/usr/bin/opencpn" were not uselessly linked against it (they use none of its symbols). Some gcc and ld warnings: src/s52plib.cpp: In member function 'int s52plib::dda_tri(wxPoint*, S52color*, render_canvas_parms*, render_canvas_parms*)': src/s52plib.cpp:5158:21: warning: 'r' may be used uninitialized in this function src/s52plib.cpp:5158:24: warning: 'g' may be used uninitialized in this function src/s52plib.cpp:5158:27: warning: 'b' may be used uninitialized in this function src/s57chart.cpp: In member function 'void s57chart::CreateSENCRecord(OGRFeature*, FILE*, int, S57Reader*)': src/s57chart.cpp:4796:53: warning: format '%d' expects type 'int', but argument 3 has type 'size_t' src/tri.c:125:1: warning: 'cvsid_aw' defined but not used src/myiso8211/ddfrecord.cpp: In member function 'int DDFRecord::Write()': src/myiso8211/ddfrecord.cpp:285:58: warning: format '%05d' expects type 'int', but argument 3 has type 'size_t' src/myiso8211/ddfrecord.cpp:289:64: warning: format '%05d' expects type 'int', but argument 3 has type 'size_t' src/chart1.cpp: In member function 'bool MyFrame::DoChartUpdate()': src/chart1.cpp:6372:142: warning: suggest parentheses around '&&' within '||' src/chcanv.cpp: In member function 'void TCWin::OnPaint(wxPaintEvent&)': src/chcanv.cpp:10927:79: warning: suggest parentheses around comparison in operand of '==' src/cutil.c:62:1: warning: 'cvsid_aw' defined but not used src/georef.c:72:1: warning: 'cvsid_aw' defined but not used src/tcmgr.cpp: In member function 'void TCMgr::GetHightOrLowTide(time_t, int, int, float, bool, int, float&, time_t&)': src/tcmgr.cpp:754:36: warning: suggest parentheses around comparison in operand of '==' src/tcmgr.cpp:762:31: warning: suggest parentheses around comparison in operand of '==' src/tcmgr.cpp: In member function 'Station_Data* TCMgr::find_or_load_harm_data(IDX_entry*)': src/tcmgr.cpp:1057:63: warning: array subscript is below array bounds src/tcmgr.cpp: In member function 'double TCMgr::blend_tide(time_t, int, int, double)': src/tcmgr.cpp:2857:15: warning: array subscript is below array bounds src/gpxdocument.cpp: In static member function 'static int GpxDocument::GetRandomNumber(int, int)': src/gpxdocument.cpp:131:52: warning: integer overflow in expression plugins/dashboard_pi/src/dashboard_pi.cpp: In member function 'void DashboardWindow::SetInstrumentList(wxArrayInt)': plugins/dashboard_pi/src/dashboard_pi.cpp:1539:34: warning: 'instrument' may be used uninitialized in this function /usr/bin/ld: Warning: alignment 4 of symbol `gps_link_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_waypt_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_category_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_rte_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_rte_link_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_trk_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_trk_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_run_crs_trk_hdr_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_run_crs_trk_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_prx_waypt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_prx_waypt_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_almanac_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_almanac_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_position_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_position_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_pvt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_pvt_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_waypt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_lap_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_lap_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_workout_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_workout_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_workout_occurrence_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_user_profile_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_user_profile_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_workout_limits_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_course_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_course_lap_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_course_lap_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_course_point_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_course_point_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_course_limits_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_category_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsapp.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_category_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_waypt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_trk_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_prx_waypt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_almanac_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_position_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_pvt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_lap_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_course_point_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_course_limits_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpscom.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_link_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_waypt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_waypt_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_rte_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_trk_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_trk_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_prx_waypt_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 8 of symbol `gps_prx_waypt_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_almanac_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_almanac_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsprot.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_position_transfer' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsrqst.c.o) /usr/bin/ld: Warning: alignment 4 of symbol `gps_position_type' in libGARMINHOST.a(garmin_wrapper.cpp.o) is smaller than 16 in libGARMINHOST.a(gpsrqst.c.o) -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/BANLkTi=b_YCZb4bwwzWdAvwbwtzA=f5...@mail.gmail.com
