Hello!

On Sat 19 Feb 2005 14:45, Victor Seva wrote:
> Oh!... I thought that Sean wants me to close the bug right now... so
> Thanks fEnIo.

Even if my Logitech QuickCam Notebook Pro will arrive this night, I
tried the latest pwc-source_10.0.6a-9, but there's a problem with
'make-kpkg modules_image'.

I usually compile my modules on a kernel different from that I'm
running and while other modules like ALSA, ipw2100 and thinkpad
compile correctly, pwc compiles for the current running kernel:
=====
[EMAIL PROTECTED]:~/src/linux-2.6.11-rc4-acpi$ make-kpkg modules_image
<cut>
Module /usr/src/modules/alsa-driver processed fine
make[1]: Entering directory `/home/luca/src/modules/pwc'
<cut>
#dh_clean /home/luca/src/modules/pwc/debian/control
for templ in ; do \
    cp $templ `echo $templ | sed -e 's/_KVERS_/2.6.11-rc4/g'` ; \
  done
<cut>
# Build the module
/usr/bin/make
make[2]: Entering directory `/home/luca/src/modules/pwc'
/usr/bin/make -C /lib/modules/2.6.10-mh4/source
SUBDIRS=/home/luca/src/modules/pwc modules
make[3]: Entering directory
`/home/luca/src/linux-2.6.10-mh4-acpi.bluez.trackpoint'
  CC [M]  /home/luca/src/modules/pwc/pwc-if.o
<cut>
# Install the module
/usr/bin/make install DESTDIR=/home/luca/src/modules/pwc/debian/tmp
make[2]: Entering directory `/home/luca/src/modules/pwc'
/usr/bin/make -C /lib/modules/2.6.10-mh4/source
SUBDIRS=/home/luca/src/modules/pwc modules
make[3]: Entering directory
`/home/luca/src/linux-2.6.10-mh4-acpi.bluez.trackpoint'
  Building modules, stage 2.
<cut>
#dh_builddeb --destdir=/home/luca/src/linux-2.6.11-rc4-acpi/..
dh_builddeb --destdir=/home/luca/src/linux-2.6.11-rc4-acpi/..
dpkg-deb: building package `pwc-modules-2.6.11-rc4' in
`/home/luca/src/linux-2.6.11-rc4-acpi/../pwc-modules-2.6.11-rc4_10.0.6a-9+01.acpi.20050218_i386.deb'.
dh_clean
<cut>
make[1]: Leaving directory `/home/luca/src/modules/pwc'
Module /usr/src/modules/pwc processed fine
make[1]: Entering directory `/home/luca/src/modules/thinkpad'
[EMAIL PROTECTED]:~/src/linux-2.6.11-rc4-acpi$
=====

I'm quite sure this problem is caused by the missing KSRC and KVERS
parameters passed to the 'make' and 'make install' command. The
attached trivial patch fix this problem:
=====
[EMAIL PROTECTED]:~/src/linux-2.6.11-rc4-acpi$ make-kpkg modules_image
<cut>
make[1]: Entering directory `/home/luca/src/modules/pwc'
<cut>
for templ in ; do \
    cp $templ `echo $templ | sed -e 's/_KVERS_/2.6.11-rc4/g'` ; \
  done
# Build the module
/usr/bin/make KSRC=/home/luca/src/linux-2.6.11-rc4-acpi
KVER=2.6.11-rc4
make[2]: Entering directory `/home/luca/src/modules/pwc'
/usr/bin/make -C /lib/modules/2.6.11-rc4/source
SUBDIRS=/home/luca/src/modules/pwc modules
make[3]: Entering directory `/home/luca/src/linux-2.6.11-rc4-acpi'
  CC [M]  /home/luca/src/modules/pwc/pwc-if.o
<cut>
# Install the module
/usr/bin/make install DESTDIR=/home/luca/src/modules/pwc/debian/tmp
KSRC=/home/luca/src/linux-2.6.11-rc4-acpi KVER=2.6.11-rc4
make[2]: Entering directory `/home/luca/src/modules/pwc'
/usr/bin/make -C /lib/modules/2.6.11-rc4/source
SUBDIRS=/home/luca/src/modules/pwc modules
make[3]: Entering directory `/home/luca/src/linux-2.6.11-rc4-acpi'
  Building modules, stage 2.
<cut>
dh_builddeb --destdir=/home/luca/src/linux-2.6.11-rc4-acpi/..
dpkg-deb: building package `pwc-modules-2.6.11-rc4' in
`/home/luca/src/linux-2.6.11-rc4-acpi/../pwc-modules-2.6.11-rc4_10.0.6a-9+01.acpi.20050218_i386.deb'.
<cut>
Module /usr/src/modules/pwc processed fine
[EMAIL PROTECTED]:~/src/linux-2.6.11-rc4-acpi$
=====

Please consider for inclusion. TIA.

BTW, module-assistant correctly works with pwc-source, so shouldn't
the entry in /usr/share/doc/pwc-source/TODO.Debian be removed?

Thx, bye,
Gismo / Luca

--- pwc/debian/rules.ORIG	2005-02-19 02:07:26.000000000 +0100
+++ pwc/debian/rules	2005-02-20 17:48:34.902598776 +0100
@@ -186,10 +186,10 @@
 	dh_clean -k
 
 	# Build the module
-	$(MAKE)
+	$(MAKE) KSRC=$(KSRC) KVER=$(KVERS)
 
 	# Install the module
-	$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp
+	$(MAKE) install DESTDIR=$(CURDIR)/debian/tmp KSRC=$(KSRC) KVER=$(KVERS)
 
 	dh_installdebconf
 	dh_installdocs

Attachment: pgplZuIiX2AdB.pgp
Description: PGP signature

Reply via email to