On Saturday 15 January 2005 15:16, Emanuele Rocca wrote: > * [ 15-01-05 - 00:12 ] Frederik Dannemare <[EMAIL PROTECTED]> wrote: > > I've set myself as owner of the ITP and I have begun working > > on the package (which has a very stange/inflexible install script, > > IMO) > > Yep, I started working on it. > If you want to take a look at my work, to avoid duplicated efforts, > you can grab the initial modifications here: > http://people.debian.org/~ema/packages/ [ snip ]
Looks good. I have a couple of suggestions for debian/rules, though. 1) I think using "dh_installchangelogs files/CHANGELOG" will automatically install the CHANGELOG file as /usr/share/doc/rkhunter/changelog.gz so it should not be necessary to do the manual mv that file into place. 2) I think the db/* files (maybe also the tmp/ dir) should go in /var/lib... instead og /usr/lib... since those db files are subject to changes when new scanning/detection methods are added to rkhunter (if the db files somehow can be updated on a regular basis similarly to how clamav-freshclam does it). Just a thought. Best regards, -- Frederik Dannemare | mailto:[EMAIL PROTECTED] http://qa.debian.org/developer.php?login=Frederik+Dannemare http://frederik.dannemare.net | http://www.linuxworlddomination.dk -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]