Il 02/01/19 12:15, Reco ha scritto:
What about this:
DEVNAME=/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_ \
sh -x /lib/udev/hdparm >> /tmp/hdparm.log 2>&1
I had tried it, too, and it looks in line with the results:
+ set -e
+ [ -n /dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_ ]
+ . /lib/hdparm/hdparm-functions
+ [ -e /proc/cmdline ]
+ grep -wq nohdparm /proc/cmdline
+ raidstat=OK
+ [ -e /proc/mdstat ]
+ egrep -iq resync|repair|recover|check /proc/mdstat
+ [ OK = OK ]
+ hdparm_options
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_
+ local
WANTED_DISK=/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_
+ local DISC= DEFAULT= DEF_QUIET= COMMAND_LINE=
+ local OPTIONS OPT_QUIET KEY SEP VALUE
+ egrep -v ^[[:space:]]*(#|$) /etc/hdparm.conf
+ hdparm_try_apm
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_
+ [ -z ]
+ udevadm info -n
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_ -q property
+ sed -n s/^ID_PATH=//p
+ local ID_PATH=pci-0000:15:00.1-ata-2
+ [ -z ]
+ udevadm info -n
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_ -q property
+ sed -n s/^ID_ATA_FEATURE_SET_APM=//p
+ local ID_ATA_FEATURE_SET_APM=1
+ [ 1 = 1 ]
+ return 0
+ hdparm_is_on_battery
+ on_ac_power
+ [ 255 -eq 1 ]
+ hdparm_set_option -B254
+ local NEW_OPT= NEW_DEF=
+ test -n
+ DEFAULT= -B254
+ read KEY SEP VALUE
+ [ -h /dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_ ]
+ readlink -m /dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_
+ DISC=/dev/sdb
+ DISC=/dev/sdb
+ OPTIONS= -B254
+ OPT_QUIET=
+ read KEY SEP VALUE
+ hdparm_is_on_battery
+ on_ac_power
+ [ 255 -eq 1 ]
+ hdparm_set_option -B1
+ local NEW_OPT= NEW_DEF=
+ test -n /dev/sdb
+ test x-B != x-B
+ NEW_OPT=
+ OPTIONS= -B1
+ read KEY SEP VALUE
+ hdparm_set_option -S6
+ local NEW_OPT= NEW_DEF=
+ test -n /dev/sdb
+ test x-B != x-S
+ NEW_OPT= -B1
+ OPTIONS= -B1 -S6
+ read KEY SEP VALUE
+ [ -z /dev/sdb ]
+ [ -n -B1 -S6 ]
+ [ /dev/sdb =
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_ ]
+ COMMAND_LINE=
+ read KEY SEP VALUE
+ [ -n -B254 ]
+ echo -B254
+ return 0
+ OPTIONS=-B254
+ [ -n -B254 ]
+ /sbin/hdparm -B254
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_:
setting Advanced Power Management level to 0xfe (254)
APM_level = 254
+ exit 0
(copypasted because I found out only later that Thunderbird could not
attach files from /tmp because of AppArmor)
1) am I wrong in using the by-id link to achieve a stable configuration?
You might get a race here. by-id symlinks are created by udev, so it's
possible to call hdparm udev script before actual symlink creation.
Right, I had not considered that. However, in real life it seems to be
working: I rebooted to check the DEVNAME, the script is being called
with the actual "sd" name (now /dev/sda, before /dev/sdb... I might have
had a USB stick plugged in during the previous reboot)
2) am I wrong in testing with the symlink instead of the real device name?
I'd rather remove this HDD via /sys interface as it's unused.
Apart from the fact I don't know (yet) how to do that, what good would
it do? I'm not worried about unauthorized access, I just want to spin it
down in order to, possibly, preserve it. Would removing it via /sys
achieve this goal? Other benefits to your suggestion?
3) if not, should I file a bug on hdparm?
I've tried to reproduce your problem, but 'sh -x' invocation with your
configuration file got me this:
/sbin/hdparm -B1 -S6 \
/dev/disk/by-id/ata-Hitachi_HTS543225A7A384____E2024242DBNGWJ_
I suspect that your problem cannot be explained by hdparm bug.
Hmm, you don't have that disk in your system so the readlink call in the
script will return the by-id name unchanged (I've tried that) and the
comparison isn't really valid, I'm afraid. What happens if you try with
an existing "id" for your system?
To recap, persistent names in the config seem to be ok, but the script
apparently must be invoked with the actual name. This is what udev does
and it works.
Thank you, Reco, for your help.
I'm CC'ing the maintainer for one quick feedback, if possible: SNAFU on
my part, right?
Regards,
Andrea.
