On Fri, Sep 5, 2008 at 2:42 PM, Jochen Schulz <[EMAIL PROTECTED]> wrote:
> L.V.Gandhi: > > > > #!/bin/bash > > rm -f ~/stock/flstock.csv > > grep FUTSTK ~/stock/today/$1 |grep "25/09/2008"|cut -s -d, -f9|sort -nr > > > temp > > You really shouldn't use "temp" as a name. See 'man mktemp'. > > > i=0 > > for trv in $(cat temp) > > do > > You could save this use of cat with this idiom: > > while read trv; do > # do sth. with trv > done < temp > > This iterates over the lines of the file "temp" and assigns each line to > trv. It behaves differently from your version in case one or more lines > in "temp" contains whitespace, though. > > > grep $trv ~/stock/today/$1 >> ~/stock/flstock.csv > > i=$((i+1)) > > if [ $i -eq 20 ] > > then > > exit 0 > > You probably want to "break" out of the loop. Exit exits the shell. > Thanks. > > > fi > > done > > rm -f temp > > cat ~/stock/flstock.csv |cut -s -d, -f2|sort >> ~/stock/fliquidstocks.txt > > Useless use of cat. :) > How it can be done more efficiently, please? -- L.V.Gandhi http://lvgandhi.tripod.com/ linux user No.205042
