*- On 24 Mar, James D. Freels wrote about "cannot compile v 2.2.4 of kernel with standard Debian 2.1" > > Today, I patched my v 2.2.3 source (which compiled fine) with > the new v 2.2.4 kernel source. However, it compiled with error as > shown below. I issued > > make mrproper > make oldconfig (no changes were present) > make menuconfig (just to confirm) > make dep > make clean > make bzImage > > Has anyone else experienced this? If so, how can this problem be > corrected? > > This is the first time in a very long while I have seen a kernel not > compile. > > ______________________________________________________________ > acct.c: In function `sys_acct': > acct.c:197: too few arguments to function `filp_close' > acct.c:203: too few arguments to function `filp_close' > make[2]: *** [acct.o] Error 1 > make[2]: Leaving directory `/usr/src/kernel-source-2.2.4/kernel' > make[1]: *** [first_rule] Error 2 > make[1]: Leaving directory `/usr/src/kernel-source-2.2.4/kernel' > make: *** [_dir_kernel] Error 2 > >
This is a well known 'Brown Bag' bug in the code. See http://www.linuxhq.com/lnxlists/linux-kernel/lk_9903_04/index.html#00244 for the disussion of it. --- linux/kernel/acct.c.~1~ Tue Mar 23 16:14:01 1999 +++ linux/kernel/acct.c Tue Mar 23 16:34:55 1999 @@ -194,13 +194,13 @@ } if (old_acct) { do_acct_process(0,old_acct); - filp_close(old_acct); + filp_close(old_acct, NULL); } out: unlock_kernel(); return error; out_err: - filp_close(file); + filp_close(file, NULL); goto out; } - -- Brian --------------------------------------------------------------------- "Never criticize anybody until you have walked a mile in their shoes, because by that time you will be a mile away and have their shoes." - unknown Mechanical Engineering [EMAIL PROTECTED] Purdue University http://www.ecn.purdue.edu/~servis ---------------------------------------------------------------------
