On Fri, 2026-02-27 at 21:31 +0100, Sven Geuer wrote: > Hello Fukui-san, > > On Fri, 2026-02-27 at 11:06 +0900, Daichi Fukui wrote: > > Dear team, > > > > This is my first post here in quite a while. > > I am looking for a sponsor for an update to shishi (1.0.3-6). > > > > The draft package is on mentors: > > https://mentors.debian.net/package/shishi/ > > > > Alternatively it can be downloaded with: > > dget -x > > https://mentors.debian.net/debian/pool/main/s/shishi/shishi_1.0.3-6.dsc > > > > Changes since the last upload: > > > > shishi (1.0.3-6) unstable; urgency=medium > > . > > * Add native systemd unit file for shishi-kdc with security > > hardening > > features (Closes: #1039368). > > * Drop obsolete dependency on lsb-base from shishi-kdc. > > * Bump Standards-Version to 4.7.3. > > * Remove redundant Priority: optional field from source package. > > * Update FSF address in debian/copyright to modern URL-based > > format. > > * Move administrative tools (shishid, keytab2shishi) to manpage > > section 8. > > * Fix numerous typographical errors in documentation, manpages, > > and > > source code via new patches. > > > > The package builds cleanly, and the previous Lintian errors (notably > > the > > missing systemd unit and obsolete dependency) have been addressed. > > > > I would appreciate any review and sponsorship. > > > > Regards, > > Fukui > > Will do the review. Give me a day or two.
First of all, many thanks for your work. It's great getting shishi back into testing eventually. However, before doing an upload I need to ask you to look into things I found during my review: 1. Build fails in a clean and minimal build environment like provided for instance by 'gbp buildpackage ...' using cowbuilder. Reason is a missing 'help2man' under Build-Depends-Indep. The need for help2man apparently is triggered by the move of manpages to section 8. For section 1 manpages are already part of the upstream source, hence the problem does not emerge when building 1.0.3-5. For section 8 they need to get created anew. Please add 'help2man' to the Build-Depends-Indep's in d/control. 2. d/control still declares 'Rules-Requires-Root: no' This declaration is not needed anymore, see https://lintian.debian.org/tags/redundant-rules-requires-root-no-field. Please remove this field from d/control. 3. d/shishi.install, d/ shishi-common.install, d/shishi-kdc.install contain absolute paths, i.e., paths starting with '/'. This can be verified by running 'cme check dpkg'. Please drop leading slashes from paths in d/*.install. 4. d/watch still in version 4 format Please update d/watch to version 5 format. See https://manpages.debian.org/debian-watch.5.html and https://manpages.debian.org/uscan-templates.5.html for details. Finally, would you mind to supply an updated 1.0.3-6 as a merge request (MR) in salsa? From the team's perspective the main advantage would be that the import to the team's namespace would reflect your individual commits instead one big commit containing all your changes. Also, it eases the review process to some degree. For you, it would allow you to benefit from salsa's ci features. Build failures and lintian issues get detected easily. Looking forward to your updates. Sven -- GPG Fingerprint 3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585
signature.asc
Description: This is a digitally signed message part
