Hi Joost,
as announced[1] I'm trying to update Debian Science R packages to have a
set of up to date R packages at freeze time. When I had a look into
r-cran-yaml which has a newer upstream as well I was stumbling upon the
fact that you are deleting unneeded files inside a pre-build target in
debian/rules. These are unneeded code copies of libyaml which are
unneeded due to dynamic linking with the library in Debian's libyaml
package. I admit for clarity reasons I'd prefer to strip those files
right from upstream source in a Files-Excluded field.
To make clear what I mean I've commited a prosed solution to Git and
wonder what might be your opinion about this. As far as I can see also
src/yaml_private.h should be deleted.
Furthermore I personally would prefer to do the other part of the
pre-build target
sed -i 's/#include "yaml.h"/#include <yaml.h>/' src/implicit.c
sed -i 's/#include "yaml.h"/#include <yaml.h>/' src/r-ext.h
echo 'PKG_LIBS = -lyaml' >> src/Makevars
rather in a quilt patch than in d/rules. I'd consider this the usual
way I've seen it in many packages and its to my personal taste more
transparent.
Before I keep on with the proposed changes I would like to hear your
opinion about this. If you don't like it I'd happily revert the
current changes.
Kind regards
Andreas.
[1] https://lists.debian.org/debian-science/2016/11/msg00054.html
--
http://fam-tille.de
--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
