On 15/09/15 09:24, Ansgar Burchardt wrote:
Ghislain Vaillant <ghisv...@gmail.com> writes:
In the patch you provided, d/rules is modified with:
# Uncomment this to turn on verbose mode.
#export DH_VERBOSE=1
+DEB_HOST_ARCH=$(shell dpkg-architecture -qDEB_HOST_ARCH)
+
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic
export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
+ifeq ($(DEB_BUILD_ARCH), ppc64el)
+DEB_CFLAGS_MAINT_APPEND += -mno-altivec
+endif
+
%:
dh $@ --sourcedirectory=src \
--buildsystem=cmake \
Isn't it s/DEB_HOST_ARCH/DEB_BUILD_ARCH at the beginning?
I think it should be DEB_HOST_ARCH (also below).
From man:dpkg-architecture(1):
| build machine: The machine the package is built on.
| host machine: The machine the package is built for.
and I assume this is not for some helper programs intended to be run as
part of the build (on the build machine), but for the binaries that
should end up in the package.
Ansgar
I am still confused with regards to what the proposed patch does.
The first change queries DEB_HOST_ARCH from dpkg-architecture, but the
latter is used nowhere afterwards.
The second change appends the necessary flag in case a build for ppc64el
is detected via DEB_BUILD_ARCH. However, DEB_BUILD_ARCH does not look
defined / queried from anywhere.
Hence my confusion, probably due to my limited experience on arch
specific build options in d/rules.
Ansgar, do you acknowledge that this patch is indeed correct?
Many thanks for your explanation.
Ghislain
--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers
