Hi,

Le 31/07/2014 16:21, Sylvestre Ledru a écrit :
On 26/07/2014 10:09, Julien Puydt wrote:
Hi,

sorry it took so long to answer.

Could you tell me the full name of the patch author?
Alexander Ovchinnikov

and whether the
patch was already forwarded upstream?
Probably not :)

S


I'm a bit annoyed because now that I have reread the patch before pushing it upstream :

- there is the part about the friend declarations and default values at the beginning, which I understand is the main topic of the patch ;

- but then there are places where *calls* to the above functions are modified, to add an argument... and this puzzles me : aren't default values precisely there to avoid giving default values for those arguments? Here is an example:
-#define RESTRICT(a,b) prestrict(a,b,MODULUS)
+#define RESTRICT(a,b) prestrict(a,b,MODULUS, 0)


So I'm wondering if the patch is really correct, because those changes don't look legit.

Snark on #debian-science

--
debian-science-maintainers mailing list
debian-science-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Reply via email to