On 12/17/18 10:45 PM, Utkarsh Gupta wrote: > Hi, > > I've prepared the Debian package of the Ruby gem snorlax. The package was > tested on sbuild and was successfully built. It is also lintian-clean. I've > uploaded the package to the salsa repo which may be found at > https://salsa.debian.org/ruby-team/ruby-snorlax > > This was an unpackaged gem listed at > https://git.fosscommunity.in/debian-ruby/TaskTracker/issues/135 > > Please consider to review and upload it.
Welcome to ruby-team! Some comments, 1. ruby-rails package version is special, it uses an epoch, so it should be ruby-rails (>= 2:4.1~) ~ at the end makes backporting easy, so its a good practice. See https://www.debian.org/doc/debian-policy/ch-controlfields.html#version and https://wiki.debian.org/SimpleBackportCreation#Indicate_in_the_changelog_a_backport_revision_number 2. The description line should be broken close to 80 characters, but should not be greater than 80. You have broken it close to 60 characters. Please fix these two issues and I can upload your package.
signature.asc
Description: OpenPGP digital signature
