On Sun, Jan 15, 2017 at 10:03:40PM +0530, Pirate Praveen wrote: > On ഞായര് 15 ജനുവരി 2017 09:42 വൈകു, Antonio Terceiro wrote: > > I would prefer to not do that this close to a freeze. Is there a good > > reason for the fork? What are the differences between the fork and the > > original? > > > > Its basically backported changes from newer releases to 2.5 version. > > From README.md, > > Turbolinks 5 is a ground-up rewrite with a new flow, new events, but the > same core idea. It's available at > [turbolinks/turbolinks](https://github.com/turbolinks/turbolinks). > Releases for v2.5 stalled while version 3 was in development, but > valuable changes were made on the [master > branch](https://github.com/turbolinks/turbolinks-classic/commits/master). > This repository is a fork with some changes from Turbolinks 2/3 before > the rewrite, with the potential to backport small fixes from version 5 > if needed.
This means that when upgrading the Rails stack to Rails 5 for buster we would need to change it back. I would rather not do that. I'm assuming that the actual code changes are relevant to gitlab. In that case, you can add that as a patch on top of turbolinks, and provide the relevant gemspec to make your life easier. Otherwise, please just patch gitlab to accept the original turbolinks.
signature.asc
Description: PGP signature
