Hello Cedric,
On Sat, Aug 17, 2013 at 1:51 PM, Cédric Boutillier < cedric.boutill...@gmail.com> wrote: > Hi Nitesh, > > On Fri, Aug 16, 2013 at 09:15:05PM +0530, Nitesh A Jain wrote: > > I have updated ruby-arel to the latest upstream > > I have pushed the changes to > > > http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-arel.git > > > Can anyone review it and upload it > > Thanks! > > Here are a few comments: > > in debian/changelog: > - The target suite is still UNRELEASED. > Changed to unstable > - You didn't indicated your changes in the changelog: (test suite added, > docs installed, Standards-Version changed,...). > I have added these to changelog > - Also, there is no need to precise Team upload, if you added yourself > to Uploaders. Chose just one of the two approaches. Putting you in the > Uploaders field means you want to take long term responsabilities for > that package. If it is a one-time update, I would chose just Team > upload, and not put myself to Uploaders. > Removed Team Upload > In debian/copyright: I see you split the License paragraph out. Maybe it > makes more sense to move it at the end of the file, so that the Files: > paragraph are grouped together. > Moved the license paragraph to the end of the file > You ignored all test failures for ruby1.8. The error is due to multiple > loading of test/support/fake_record.rb, creating each time a new > superclass for Column (and Spec). This could be solved with something > like: > --- a/test/support/fake_record.rb > +++ b/test/support/fake_record.rb > @@ -1,5 +1,6 @@ > module FakeRecord > - class Column < Struct.new(:name, :type) > + Column = Struct.new(:name, :type) > + class Column > end > > (is there a better way?) > > > (same for Spec further in the same file) > But then I get 7 errors due Float::INFINITY inexistent for ruby1.8. > Since ruby1.8 will be dropped, then probably it is not worth spending > too much effort. > Since ruby1.8 will be dropped, I ignored the test > > Cheers, > > Cédric > Thanks for the review Hope its up to the mark now Regards Nitesh
