Hi Cedric. Thank you for the review I will incorporate it and re-upload the package
On Sat, May 18, 2013 at 7:48 PM, Cédric Boutillier <cedric.boutill...@gmail.com> wrote: > > Hi Nitesh, > > On Thu, May 16, 2013 at 08:50:13PM +0530, Nitesh A Jain wrote: >> Hi, > >> I prepared the packaging of ruby-rainbow. It is lintian clean >> and tested with pbuilder. Further information about this package can >> be accessed from the URL : > >> http://mentors.debian.net/package/ruby-rainbow > >> Alternatively, one can download the package with dget using this command: > >> dget -x >> http://mentors.debian.net/debian/pool/main/r/ruby-rainbow/ruby-rainbow_1.1.4-1.dsc > >> Also , I've added my package to the following git-repo : > >> https://git.gitorious.org/ruby-rainbow/ruby-rainbow.git > > Here is a list of comments, that would help improving the package: > > debian/control: > - remove DM-Upload-Allowed: line deprecated > - bump Standards-Version to 3.9.4 (current version of the policy) > - remove the # sign in front of Vcs-* fields, if you consider > maintaining this package inside the Ruby Team (I guess it is the case, > the way you set the Maintainer: field > - the short and long description can be improved: > + the short one should not be a real sentence. Something like: > "extension of Ruby String class enabling coloring text on ANSI terminals" > + the long one should be reformulated to better explain the user the > goal of the package (lists may need to disappear, as > the information they provide is too detailed) > - the URL in the Homepage: field does not seem to be the homepage of the > project. Should probably be: > https://github.com/sickill/rainbow > > debian/ruby-rainbow.docs > - you have still boilerplate code: remove first line and uncomment the > second > > debian/ruby-tests.rb > - you have still boilerplate code. Everything is commented. As a > consequence, tests are not run at build time. > Putting > require 'test/rainbow_test' > should be enough. > The tests pass when I run dpkg-buildpackage, but I've got 10 failures > with git-buildpackage --git-pbuilder. I didn't investigate why. Maybe > some environment variable has be to set so that the coloring is > activated in the pbuilder environment. > > debian/copyright: > - it is considered good practice to chose for the license of debian/* > files the same license as upstream to ease distribution. Consider > switching to Expat. If you do this, you can move the text of the Expat > license to a standalone license paragraph, and just refer to this > paragraph in the Files: paragraph with the one-line License: Expat. > See Example 2 in > > http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph > > Cheers, > > Cédric -- To UNSUBSCRIBE, email to debian-ruby-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cac1a26+i76w4omn0wfqj0c600p2qhgyfy+sp+aoeq_iaxzd...@mail.gmail.com
