On 06/11/16 19:59, Dmitry Shachnev wrote: > Hi Emilio, > > On Sun, Nov 06, 2016 at 04:17:55PM +0100, Emilio Pozuelo Monfort wrote: >>> Please also binNMU plasma-integration against the new qtbase. >>> >>> It links with the static library libQt5PlatformSupport.a, and should pick >>> up the new version of it. >> >> Done. I wonder if this shouldn't have a stricter dependency though. > > Do you mean that it should depend on qtbase-abi-5-x-y? > > If yes, I would like this to be the case, but as it is a plugin which just > implements the QPlatformTheme interface, and it does not use any Qt private > symbols. And as there are no private symbols on it, it does not get such a > dependency. > > In this particular case, a new method was added to its (pure virtual) parent > class (with the default implementation), and the rebuild makes sure that > this method can be called.
I mean if changes in qtbase can break this package, then it probably needs a stricter dependency than it currently has. But maybe it's qtbase's fault for breaking the public ABI (if that is considered an ABI break. I'm not too familiar with C++ ABI so I can't say). But I'll just leave this up to you. Cheers, Emilio
