Package: release.debian.org Severity: normal Tags: jessie User: release.debian....@packages.debian.org Usertags: pu
This small programming error causes DKIM signature validation to fail in some cases where it should not. Making this change in stable will increase DKIM reliability which is critical for safe use of e-mail authentication. The patch is what upstream is shipping in 2.11 which is what I plan to use for stretch. The regression risk for this change is neglibible.
diff -Nru opendkim-2.9.2/debian/changelog opendkim-2.9.2/debian/changelog --- opendkim-2.9.2/debian/changelog 2014-11-28 16:22:24.000000000 -0500 +++ opendkim-2.9.2/debian/changelog 2016-10-29 17:05:59.000000000 -0400 @@ -1,3 +1,10 @@ +opendkim (2.9.2-2+deb8u1) stable; urgency=medium + + * Fix relaxed canonicalization of folded headers breaks signatures, fix + backported from upstream 2.11.0 (Closes: #840015) + + -- Scott Kitterman <sc...@kitterman.com> Sat, 29 Oct 2016 16:41:59 -0400 + opendkim (2.9.2-2) unstable; urgency=medium * Cherry-pick bug fixes from upstream development of version 2.10 diff -Nru opendkim-2.9.2/debian/patches/series opendkim-2.9.2/debian/patches/series --- opendkim-2.9.2/debian/patches/series 2014-11-28 16:04:42.000000000 -0500 +++ opendkim-2.9.2/debian/patches/series 2016-10-29 17:03:58.000000000 -0400 @@ -10,3 +10,4 @@ 0010-Handle-empty-values-of-i-reported-by-MTAs.patch 0011-Make-a-reference-from-the-DNS-service-functions-to-d.patch 0013-Patch-32-Re-arrange-the-execution-logic-to-drop-priv.patch +ticket226.patch diff -Nru opendkim-2.9.2/debian/patches/ticket226.patch opendkim-2.9.2/debian/patches/ticket226.patch --- opendkim-2.9.2/debian/patches/ticket226.patch 1969-12-31 19:00:00.000000000 -0500 +++ opendkim-2.9.2/debian/patches/ticket226.patch 2016-10-29 17:03:14.000000000 -0400 @@ -0,0 +1,18 @@ +Description: Fix Bug226 (Bad signature of From:\r\n wrapped field) + solve validation problems with amazon messages +Author: A.Schulze +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +Index: dv-opendkim-2.10.3/libopendkim/dkim-canon.c +=================================================================== +--- dv-opendkim-2.10.3.orig/libopendkim/dkim-canon.c ++++ dv-opendkim-2.10.3/libopendkim/dkim-canon.c +@@ -388,7 +388,7 @@ dkim_canon_header_string(struct dkim_dst + } + + /* skip all spaces before first word */ +- while (*p != '\0' && DKIM_ISWSP(*p)) ++ while (*p != '\0' && DKIM_ISLWSP(*p)) + p++; + + space = FALSE; /* just saw a space */
