On Sat, Jun 25, 2016 at 15:53:18 -0400, Robert Edmonds wrote:
> Package: release.debian.org
> Severity: normal
> Tags: jessie
> User: release.debian....@packages.debian.org
> Usertags: pu
>
> Hi,
>
> The unbound package in jessie is affected by #807132 ("unbound-control
> breaks systemctl stop/start"). The bug report is long, but briefly, the
> unbound daemon can fail to start in several common scenarios, such as
> when the "unbound-control" utility is used to stop the daemon. One user
> reports that the unbound daemon is stopped but not subsequently started
> every time the unbound package is upgraded. This bug has been fixed in
> unstable by 1.5.9-1 and is currently marked severity important, though
> in my opinion this bug is severe enough to make it unsuitable for a
> release.
>
> The fix for this is shown below and is relatively simple, and was
> suggested by a member of the pkg-systemd team (Michael Biebl).
>
> I'd like to upload this to jessie.
>
May I take the opportunity to ask you to also fix the 'stop' action from
the init script?
We've been using this patch on the debian.org hosts for a year now.
Previously restarting the service would quite often result in no running
unbound, because (AIUI) systemd doesn't use the init script 'restart'
action (uses stop && start instead), the 'stop' action would not wait
for the process to actually die before returning, and then 'start' would
say "I'm already running, nothing to do".
--- /tmp/unbound-1.4.22/debian/unbound.init 2016-02-22 01:43:22.000000000
+0200
+++ modules/unbound/files/unbound.init 2015-05-17 16:50:09.699383800 +0200
@@ -121,7 +121,7 @@
stop)
if $UNBOUND_ENABLE; then
log_daemon_msg "Stopping $DESC" "$NAME"
- if start-stop-daemon --stop --quiet --oknodo --pidfile $PIDFILE
--name $NAME; then
+ if start-stop-daemon --stop --quiet --oknodo --pidfile $PIDFILE
--name $NAME --retry 5; then
do_resolvconf_stop
log_end_msg 0
else
Cheers,
Julien
